build: update Go to version 1.23.2 (#985)

The updated staticcheck application which is needed for go 1.23
seems to have broken multi-part config file loading. The file
within the plugins dir ignored a known warning about protobufs
which is now triggering. Adding a top level config again
suppresses it.

Author: jrasell

.go-version

@@ -1 +1 @@
-1.22.6
+1.23.2

.golangci.yml

@@ -8,7 +8,7 @@ run:
 # output configuration options
 output:
   # colored-line-number|line-number|json|tab|checkstyle|code-climate, default is "colored-line-number"
-  format: colored-line-number
+  formats: colored-line-number
 
   # print lines of code with issue, default is true
   print-issued-lines: true

CHANGELOG.md

@@ -4,6 +4,7 @@ BUG FIXES:
 * config: Fixed a bug where the Nomad strategy and target plugins would fail to connect to Nomad's Task API socket [[GH-966](https://github.com/hashicorp/nomad-autoscaler/pull/966)]
 
 IMPROVEMENTS:
+* build: Updated to Go 1.23.2 [[GH-985](https://github.com/hashicorp/nomad-autoscaler/pull/985)]
 * scaleutils: Add new node selector option `oldest_create_index` to select nodes with the oldest creation date  [[GH-961](https://github.com/hashicorp/nomad-autoscaler/pull/961)] 
 
 ## 0.4.5 (August 13, 2024)

Dockerfile

@@ -10,7 +10,7 @@
 
 # devbuild compiles the binary
 # -----------------------------------
-FROM golang:1.22 AS devbuild
+FROM golang:1.23 AS devbuild
 
 # Disable CGO to make sure we build static binaries
 ENV CGO_ENABLED=0

GNUmakefile

@@ -32,7 +32,7 @@ tools: lint-tools test-tools generate-tools
 .PHONY: generate-tools
 generate-tools: ## Install the tools used to generate code
 	@echo "==> Installing code generate tools..."
-	go install github.com/bufbuild/buf/cmd/buf@v1.27.2
+	go install github.com/bufbuild/buf/cmd/buf@v1.45.0
 	go install github.com/golang/protobuf/[email protected]
 	@echo "==> Done"
 
@@ -45,8 +45,8 @@ test-tools: ## Install the tools used to run tests
 .PHONY: lint-tools
 lint-tools: ## Install the tools used to lint
 	@echo "==> Installing lint tools..."
-	go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.56.2
-	go install honnef.co/go/tools/cmd/staticcheck@2023.1.3
+	go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.61.0
+	go install honnef.co/go/tools/cmd/staticcheck@2024.1.1
 	go install github.com/hashicorp/go-hclog/[email protected]
 	go install github.com/hashicorp/hcl/v2/cmd/hclfmt@d0c4fa8b0bbc2e4eeccd1ed2a32c2089ed8c5cf1
 	@echo "==> Done"
@@ -86,7 +86,7 @@ proto: ## Generate the protocol buffers
 lint: lint-tools generate-tools hclfmt ## Lint the source code
 	@echo "==> Linting source code..."
 	@GOPROXY=direct \
-	golangci-lint run -j 1 --build-tags "$(GO_TAGS)"
+	golangci-lint run -j 1 --build-tags "$(GO_TAGS)" --timeout=8m
 	@staticcheck ./...
 	@hclogvet .
 	@buf lint --config=./tools/buf/buf.yaml

go.mod

@@ -1,6 +1,6 @@
 module github.com/hashicorp/nomad-autoscaler
 
-go 1.22
+go 1.23
 
 require (
 	github.com/Azure/azure-sdk-for-go v68.0.0+incompatible

plugins/test/noop-apm/go.mod

@@ -1,6 +1,6 @@
 module github.com/hashicorp/nomad-autoscaler/plugins/test/noop-apm
 
-go 1.22
+go 1.23
 
 require (
 	github.com/hashicorp/go-hclog v1.6.3

plugins/test/noop-strategy/go.mod

@@ -1,6 +1,6 @@
 module github.com/hashicorp/nomad-autoscaler/plugins/test/noop-strategy
 
-go 1.22
+go 1.23
 
 require (
 	github.com/hashicorp/go-hclog v1.6.3

plugins/test/noop-target/go.mod

@@ -1,6 +1,6 @@
 module github.com/hashicorp/nomad-autoscaler/plugins/test/noop-target
 
-go 1.22
+go 1.23
 
 require (
 	github.com/hashicorp/go-hclog v1.6.3

staticcheck.conf

@@ -0,0 +1,2 @@
+# https://github.com/hashicorp/nomad-autoscaler/issues/984
+checks = ["-SA1019"]