agent: drop atlas/scada code #3032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slackpad
reviewed
May 10, 2017
command/agent/config.go
Outdated
| DeprecatedAtlasInfrastructure string `mapstructure:"atlas_infrastructure"` | ||
| DeprecatedAtlasToken string `mapstructure:"atlas_token" json:"-"` | ||
| DeprecatedAtlasACLToken string `mapstructure:"atlas_acl_token" json:"-"` | ||
| DeprecatedAtlasJoin bool `mapstructure:"atlas_join"` |
There was a problem hiding this comment.
if you json:"-" these as well they won't show up in /v1/agent/self
| if err := c.Command.Parse(c.args); err != nil { | ||
| return nil | ||
| } | ||
|
|
||
| // check deprecated flags |
There was a problem hiding this comment.
Will these basically be duplicate warnings with the others you have below?
There was a problem hiding this comment.
no since the ones will be for the HTTP endpoint and the other ones for the command line. I'll add the ==> prefix though.
magiconair
force-pushed
the
fms-drop-scada
branch
from
ed9f929 to
9eb0e5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.