fix: updates to accommodate haproxy changes in FST charts #321

jeromy-cannon · 2024-05-22T16:00:51Z

Description

This pull request changes the following:

use Running phase for proxy check during solo network deploy
remove haproxy recycle pod logic, instead use waitForPodReady which uses the PodCondition[Ready] = true that the haproxy is now setting based on the startupProbe
removed checkNetworkNodeProxyUp
use in test cases HEDERA_PLATFORM_VERSION = 'v0.49.0-alpha.2' since this is the first version to support FQDN correctly
enhanced prepareAddressBookBase64 to convert FQDN to IP addresses to support Mirror Node
enhanced nodeClient creation to set more robust timeouts and backoffs
refactored getNodeServiceMap() to use a new class NetworkNodeServices to strongly type variables and give it more attributes that can be provide more reuse
updated prepareConfigTxt() to use accountId from services instead of dynamically constructing it which could be wrong in some scenarios
added the ability to set a local environment variable SOLO_FST_CHARTS_DIR to point to the developers FST chart directory for running tests locally against a chart that hasn't been released yet

Related Issues

version.mjs

github-actions · 2024-05-22T16:04:15Z

Unit Test Results - Linux

1 files 19 suites 1m 43s ⏱️
122 tests 122 ✅ 0 💤 0 ❌
147 runs 147 ✅ 0 💤 0 ❌

Results for commit b29878c.

♻️ This comment has been updated with latest results.

github-actions · 2024-05-22T16:05:57Z

E2E Mirror Node Tests Coverage Report

8 tests 8 ✅ 5m 30s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit b29878c.

♻️ This comment has been updated with latest results.

github-actions · 2024-05-22T16:06:09Z

Unit Test Results - Windows

1 files 19 suites 1m 54s ⏱️
122 tests 122 ✅ 0 💤 0 ❌
147 runs 147 ✅ 0 💤 0 ❌

Results for commit b29878c.

♻️ This comment has been updated with latest results.

github-actions · 2024-05-22T16:06:40Z

E2E Node PEM Stop Add Tests Coverage Report

1 files 1 suites 8m 33s ⏱️
17 tests 17 ✅ 0 💤 0 ❌
19 runs 19 ✅ 0 💤 0 ❌

Results for commit b29878c.

♻️ This comment has been updated with latest results.

github-actions · 2024-05-22T16:07:50Z

E2E Tests Coverage Report

54 tests 54 ✅ 4m 50s ⏱️
9 suites 0 💤
1 files 0 ❌

Results for commit b29878c.

♻️ This comment has been updated with latest results.

github-actions · 2024-05-22T16:08:07Z

E2E Relay Tests Coverage Report

1 files 1 suites 3m 13s ⏱️
5 tests 5 ✅ 0 💤 0 ❌
6 runs 6 ✅ 0 💤 0 ❌

Results for commit b29878c.

♻️ This comment has been updated with latest results.

github-actions · 2024-05-22T16:09:36Z

E2E Node PFX Kill Add Tests Coverage Report

1 files 1 suites 10m 38s ⏱️
17 tests 17 ✅ 0 💤 0 ❌
19 runs 19 ✅ 0 💤 0 ❌

Results for commit b29878c.

♻️ This comment has been updated with latest results.

github-actions · 2024-05-22T16:11:59Z

E2E Node Local Build Tests Coverage Report

8 tests 8 ✅ 5m 12s ⏱️
2 suites 0 💤
1 files 0 ❌

Results for commit b29878c.

♻️ This comment has been updated with latest results.

src/core/account_manager.mjs

package.json

test/e2e/e2e_node_util.js

codacy-production · 2024-05-29T18:41:01Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for `7b4e5b7`¹	✅ 96.30%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`7b4e5b7`)	Report Missing	Report Missing	Report Missing
Head commit (`b29878c`)	3375	2752	81.54%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#321)	162	156	96.30%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more}

Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

codecov · 2024-05-29T18:44:28Z

Codecov Report

Attention: Patch coverage is 96.05911% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 82.23%. Comparing base (0efe626) to head (b29878c).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
+ Coverage   81.65%   82.23%   +0.58%     
==========================================
  Files          34       35       +1     
  Lines        3973     4020      +47     
  Branches      628      638      +10     
==========================================
+ Hits         3244     3306      +62     
+ Misses        729      714      -15

Files	Coverage Δ
src/commands/flags.mjs	`94.73% <ø> (ø)`
src/commands/mirror_node.mjs	`68.80% <100.00%> (ø)`
src/commands/network.mjs	`51.92% <100.00%> (ø)`
src/core/config_manager.mjs	`91.56% <100.00%> (ø)`
src/core/constants.mjs	`94.73% <100.00%> (+0.23%)`	⬆️
src/core/k8.mjs	`87.36% <ø> (-0.45%)`	⬇️
src/core/platform_installer.mjs	`89.63% <100.00%> (+0.06%)`	⬆️
src/core/templates.mjs	`83.11% <100.00%> (+1.68%)`	⬆️
test/e2e/e2e_node_util.js	`88.60% <100.00%> (+0.44%)`	⬆️
version.mjs	`100.00% <100.00%> (ø)`
... and 4 more

Signed-off-by: Jeromy Cannon <[email protected]>

…ode.test.mjs to verify the consensus nodes are working before kicking off the mirror node deploy Signed-off-by: Jeromy Cannon <[email protected]>

Signed-off-by: Jeromy Cannon <[email protected]>

Signed-off-by: Matt Riben <[email protected]>

Signed-off-by: Jeromy Cannon <[email protected]>

…ress to support mirror node Signed-off-by: Jeromy Cannon <[email protected]>

…raph/sdk release with the log file constructor changes Signed-off-by: Jeromy Cannon <[email protected]>

Signed-off-by: Jeromy Cannon <[email protected]>

leninmehedy

Thanks

## [0.26.0](v0.25.0...v0.26.0) (2024-05-31) ### Features * mount application.env as a configMap ([#310](#310)) ([3158436](3158436)) ### Bug Fixes * fix freeze timestamp for node add command ([#327](#327)) ([0aedeb1](0aedeb1)) * refactor waitForPod and waitForPodConditions to stabilize code timeouts during e2e tests ([#317](#317)) ([ca7b21b](ca7b21b)) * the wrong pod name ([#322](#322)) ([5c50579](5c50579)) * updates to accommodate haproxy changes in FST charts ([#321](#321)) ([8997849](8997849))

swirlds-automation · 2024-05-31T15:26:09Z

🎉 This PR is included in version 0.26.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

jeromy-cannon commented May 22, 2024

View reviewed changes

version.mjs Outdated Show resolved Hide resolved

jeromy-cannon self-assigned this May 23, 2024

jeromy-cannon force-pushed the 00312-haproxy-changes branch from 5dd90f3 to 413741d Compare May 23, 2024 10:34

jeromy-cannon commented May 23, 2024

View reviewed changes

src/core/account_manager.mjs Outdated Show resolved Hide resolved

jeromy-cannon force-pushed the 00312-haproxy-changes branch 2 times, most recently from 1e70c58 to 3142544 Compare May 28, 2024 11:37

jeromy-cannon commented May 28, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

jeromy-cannon commented May 28, 2024

View reviewed changes

test/e2e/e2e_node_util.js Outdated Show resolved Hide resolved

jeromy-cannon commented May 28, 2024

View reviewed changes

test/e2e/e2e_node_util.js Outdated Show resolved Hide resolved

jeromy-cannon commented May 28, 2024

View reviewed changes

test/e2e/e2e_node_util.js Outdated Show resolved Hide resolved

jeromy-cannon and others added 10 commits May 29, 2024 19:51

updates to remove recycle of haproxy

7745aac

Signed-off-by: Jeromy Cannon <[email protected]>

TODO

9e74ffc

Signed-off-by: Jeromy Cannon <[email protected]>

updated call in test for checking if node proxy is up

a5eb0d2

Signed-off-by: Jeromy Cannon <[email protected]>

updated call in test for checking if node proxy is up

54837a0

Signed-off-by: Jeromy Cannon <[email protected]>

updated call in test for checking if node proxy is up

d2124af

Signed-off-by: Jeromy Cannon <[email protected]>

updated client logger to accept more robust settings and a log file

1442c37

Signed-off-by: Jeromy Cannon <[email protected]>

moved balanceQueryShouldSucceed to test_util to be reused by mirror_n…

b2adb11

…ode.test.mjs to verify the consensus nodes are working before kicking off the mirror node deploy Signed-off-by: Jeromy Cannon <[email protected]>

updated to use non-headless service

28c21ba

Signed-off-by: Jeromy Cannon <[email protected]>

enable config log messages

acdabb2

Signed-off-by: Matt Riben <[email protected]>

updated to support domain names in address book from ledger

a8fb584

Signed-off-by: Jeromy Cannon <[email protected]>

jeromy-cannon added 3 commits May 29, 2024 19:51

fixed typo

67c4bad

Signed-off-by: Jeromy Cannon <[email protected]>

pushing current changes

ff0d1f9

Signed-off-by: Jeromy Cannon <[email protected]>

bump fst charts to 0.26.0

205ecd6

Signed-off-by: Jeromy Cannon <[email protected]>

jeromy-cannon force-pushed the 00312-haproxy-changes branch from 625708b to 205ecd6 Compare May 29, 2024 18:52

jeromy-cannon added 8 commits May 29, 2024 19:56

restore package.json

6f2a45d

Signed-off-by: Jeromy Cannon <[email protected]>

revert to use fqdn for externalip in config.txt

5c1f900

Signed-off-by: Jeromy Cannon <[email protected]>

restore delete namespace in test

f2ad485

Signed-off-by: Jeromy Cannon <[email protected]>

remove skips

c2b205d

Signed-off-by: Jeromy Cannon <[email protected]>

get nodeId from templated renderer in reverse

e723061

Signed-off-by: Jeromy Cannon <[email protected]>

update prepareAddressBookBase64 to handle converting FQDN into IP add…

419b0f3

…ress to support mirror node Signed-off-by: Jeromy Cannon <[email protected]>

only set the sdk logger if devMode is enabled until we get the @hashg…

0997279

…raph/sdk release with the log file constructor changes Signed-off-by: Jeromy Cannon <[email protected]>

updating naming in app and timeout for test

6915a8b

Signed-off-by: Jeromy Cannon <[email protected]>

jeromy-cannon marked this pull request as ready for review May 29, 2024 21:31

jeromy-cannon requested review from a team and leninmehedy as code owners May 29, 2024 21:31

jeromy-cannon requested review from nathanklick, JeffreyDallas and matteriben May 29, 2024 21:32

jeromy-cannon added 2 commits May 29, 2024 22:49

increase timeout

4e413da

Signed-off-by: Jeromy Cannon <[email protected]>

increase default timeout

b29878c

Signed-off-by: Jeromy Cannon <[email protected]>

leninmehedy approved these changes May 30, 2024

View reviewed changes

jeromy-cannon merged commit 8997849 into main May 30, 2024
31 checks passed

jeromy-cannon deleted the 00312-haproxy-changes branch May 30, 2024 06:59

swirlds-automation added the released label May 31, 2024

fix: updates to accommodate haproxy changes in FST charts #321

fix: updates to accommodate haproxy changes in FST charts #321

Uh oh!

Conversation

jeromy-cannon commented May 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Uh oh!

Uh oh!

github-actions bot commented May 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Results - Linux

Uh oh!

github-actions bot commented May 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Mirror Node Tests Coverage Report

Uh oh!

github-actions bot commented May 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Results - Windows

Uh oh!

github-actions bot commented May 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Node PEM Stop Add Tests Coverage Report

Uh oh!

github-actions bot commented May 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Tests Coverage Report

Uh oh!

github-actions bot commented May 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Relay Tests Coverage Report

Uh oh!

github-actions bot commented May 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Node PFX Kill Add Tests Coverage Report

Uh oh!

github-actions bot commented May 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Node Local Build Tests Coverage Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codacy-production bot commented May 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

Footnotes

Uh oh!

codecov bot commented May 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

leninmehedy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

swirlds-automation commented May 31, 2024

Uh oh!

Uh oh!

jeromy-cannon commented May 22, 2024 •

edited

Loading

github-actions bot commented May 22, 2024 •

edited

Loading

github-actions bot commented May 22, 2024 •

edited

Loading

github-actions bot commented May 22, 2024 •

edited

Loading

github-actions bot commented May 22, 2024 •

edited

Loading

github-actions bot commented May 22, 2024 •

edited

Loading

github-actions bot commented May 22, 2024 •

edited

Loading

github-actions bot commented May 22, 2024 •

edited

Loading

github-actions bot commented May 22, 2024 •

edited

Loading

codacy-production bot commented May 29, 2024 •

edited

Loading

codecov bot commented May 29, 2024 •

edited

Loading