Skip to content

feat: add UMD example #3028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 16, 2025
Merged

feat: add UMD example #3028

merged 7 commits into from
Apr 16, 2025

Conversation

ivaylonikolov7
Copy link
Contributor

@ivaylonikolov7 ivaylonikolov7 commented Apr 7, 2025 •
edited
Loading

Description:

  • Adds UMD example
  • Updates README.md to show support of UMD package

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ivaylonikolov7
feat: add example
88e7ad2 
Signed-off-by: Ivaylo Nikolov <[email protected]>
@ivaylonikolov7 ivaylonikolov7 requested review from a team as code owners April 7, 2025 08:40
@ivaylonikolov7 ivaylonikolov7 requested review from a team as code owners April 7, 2025 10:27
venilinvasilev
venilinvasilev reviewed Apr 7, 2025
View reviewed changes
@ivaylonikolov7 ivaylonikolov7 added this to the v2.63.0 milestone Apr 9, 2025
ivaylogarnev-limechain
ivaylogarnev-limechain reviewed Apr 9, 2025
View reviewed changes
ivaylogarnev-limechain
ivaylogarnev-limechain previously approved these changes Apr 16, 2025
View reviewed changes
Copy link
Contributor

@ivaylogarnev-limechain ivaylogarnev-limechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivaylonikolov7
fix: update syntax higlight
e041f40 
Signed-off-by: Ivaylo Nikolov <[email protected]>
@ivaylonikolov7 ivaylonikolov7 merged commit 582cdaa into main Apr 16, 2025
13 of 14 checks passed
@ivaylonikolov7 ivaylonikolov7 deleted the feat/add-umd-example branch April 16, 2025 11:43
@ivaylonikolov7 ivaylonikolov7 mentioned this pull request Apr 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@venilinvasilev venilinvasilev venilinvasilev left review comments

@ivaylogarnev-limechain ivaylogarnev-limechain ivaylogarnev-limechain approved these changes

@PavelSBorisov PavelSBorisov Awaiting requested review from PavelSBorisov PavelSBorisov is a code owner automatically assigned from hiero-ledger/github-maintainers

@Perseverance Perseverance Awaiting requested review from Perseverance Perseverance is a code owner automatically assigned from hiero-ledger/tsc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.63.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ivaylonikolov7 @venilinvasilev @ivaylogarnev-limechain