chore: update GitHub Actions to use latest versions of actions and Node.js (#1084)

AvivAbachi · web-flow · commit c28ac715cb22 · 2025-04-17T19:24:03.000+03:00
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -5,10 +5,10 @@ jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 20
           cache: 'npm'
       - name: Get Commit Hash and generate Version File
         run: echo "${{ github.event.pull_request.head.sha }}" >> public/hash.txt
@@ -25,10 +25,10 @@ jobs:
   build-storybook:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 20
           cache: 'npm'
       - name: Run install
         run: npm ci
@@ -39,7 +39,7 @@ jobs:
         with:
           name: dist-storybook
           path: dist/storybook
-  
+
       - name: Save PR number
         env:
           PR_NUMBER: ${{ github.event.number }}
diff --git a/.github/workflows/cd.yml b/.github/workflows/cd.yml
@@ -6,39 +6,39 @@ on:
 jobs:
   cd:
     environment: production
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
-    - name: Get Commit Hash and generate Version File
-      run: echo "$(git rev-parse --short HEAD)" >> public/hash.txt
-    - env:
-        DOCKER_APP_IMAGE_NAME: "ghcr.io/hasadna/open-bus-map-search/open-bus-map-search"
-        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        HASADNA_K8S_DEPLOY_KEY: ${{ secrets.HASADNA_K8S_DEPLOY_KEY }}
-      run: |
-        echo "${GITHUB_TOKEN}" | docker login ghcr.io -u hasadna --password-stdin &&\
-        if docker pull "${DOCKER_APP_IMAGE_NAME}:latest"; then
-          CACHE_FROM_ARG="--cache-from ${DOCKER_APP_IMAGE_NAME}:latest"
-        else
-          CACHE_FROM_ARG=""
-        fi &&\
-        docker build $CACHE_FROM_ARG --build-arg VERSION=${GITHUB_SHA} -t app . &&\
-        docker tag app "${DOCKER_APP_IMAGE_NAME}:${GITHUB_SHA}" &&\
-        docker push "${DOCKER_APP_IMAGE_NAME}:${GITHUB_SHA}" &&\
-        if [ "${GITHUB_REF}" == "refs/heads/main" ]; then
-          docker tag app "${DOCKER_APP_IMAGE_NAME}:latest" &&\
-          docker push "${DOCKER_APP_IMAGE_NAME}:latest" &&\
-          if ! git log -1 --pretty=format:"%s" | grep -- --no-deploy; then
-            cd `mktemp -d` &&\
-            echo "${HASADNA_K8S_DEPLOY_KEY}" > hasadna_k8s_deploy_key &&\
-            chmod 400 hasadna_k8s_deploy_key &&\
-            export GIT_SSH_COMMAND="ssh -i `pwd`/hasadna_k8s_deploy_key -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no" &&\
-            git clone git@github.com:hasadna/hasadna-k8s.git &&\
-            cd hasadna-k8s &&\
-            python update_yaml.py '{"mapSearchImage":"'"${DOCKER_APP_IMAGE_NAME}:${GITHUB_SHA}"'"}' apps/openbus/values-hasadna-auto-updated.yaml &&\
-            git config --global user.name "Open Bus Map Search CI" &&\
-            git config --global user.email "open-bus-map-search-ci@localhost" &&\
-            git add apps/openbus/values-hasadna-auto-updated.yaml && git commit -m "automatic update of open bus map search" &&\
-            git push origin master
+      - uses: actions/checkout@v4
+      - name: Get Commit Hash and generate Version File
+        run: echo "$(git rev-parse --short HEAD)" >> public/hash.txt
+      - env:
+          DOCKER_APP_IMAGE_NAME: 'ghcr.io/hasadna/open-bus-map-search/open-bus-map-search'
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          HASADNA_K8S_DEPLOY_KEY: ${{ secrets.HASADNA_K8S_DEPLOY_KEY }}
+        run: |
+          echo "${GITHUB_TOKEN}" | docker login ghcr.io -u hasadna --password-stdin &&\
+          if docker pull "${DOCKER_APP_IMAGE_NAME}:latest"; then
+            CACHE_FROM_ARG="--cache-from ${DOCKER_APP_IMAGE_NAME}:latest"
+          else
+            CACHE_FROM_ARG=""
+          fi &&\
+          docker build $CACHE_FROM_ARG --build-arg VERSION=${GITHUB_SHA} -t app . &&\
+          docker tag app "${DOCKER_APP_IMAGE_NAME}:${GITHUB_SHA}" &&\
+          docker push "${DOCKER_APP_IMAGE_NAME}:${GITHUB_SHA}" &&\
+          if [ "${GITHUB_REF}" == "refs/heads/main" ]; then
+            docker tag app "${DOCKER_APP_IMAGE_NAME}:latest" &&\
+            docker push "${DOCKER_APP_IMAGE_NAME}:latest" &&\
+            if ! git log -1 --pretty=format:"%s" | grep -- --no-deploy; then
+              cd `mktemp -d` &&\
+              echo "${HASADNA_K8S_DEPLOY_KEY}" > hasadna_k8s_deploy_key &&\
+              chmod 400 hasadna_k8s_deploy_key &&\
+              export GIT_SSH_COMMAND="ssh -i `pwd`/hasadna_k8s_deploy_key -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no" &&\
+              git clone git@github.com:hasadna/hasadna-k8s.git &&\
+              cd hasadna-k8s &&\
+              python update_yaml.py '{"mapSearchImage":"'"${DOCKER_APP_IMAGE_NAME}:${GITHUB_SHA}"'"}' apps/openbus/values-hasadna-auto-updated.yaml &&\
+              git config --global user.name "Open Bus Map Search CI" &&\
+              git config --global user.email "open-bus-map-search-ci@localhost" &&\
+              git add apps/openbus/values-hasadna-auto-updated.yaml && git commit -m "automatic update of open bus map search" &&\
+              git push origin master
+            fi
           fi
-        fi
diff --git a/.github/workflows/complaint.yml b/.github/workflows/complaint.yml
@@ -5,28 +5,28 @@ jobs:
     timeout-minutes: 60
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v3
-    - run: npm run docker:build
-      working-directory: src/complaint 
-    - run: npm run docker:run
-      working-directory: src/complaint
-    - uses: actions/upload-artifact@v4
-      if: always()
-      with:
-        name: playwright-trace
-        path: src/complaint/traces
-        retention-days: 30\
-    - uses: shallwefootball/s3-upload-action@master
-      name: Upload trace to S3
-      if: always()
-      id: s3-trace
-      continue-on-error: true
-      with:
-        aws_key_id: ${{ secrets.AWS_KEY_ID }}
-        aws_secret_access_key: ${{ secrets.AWS_SECRET_ACCESS_KEY}}
-        aws_bucket: noam-gaash.co.il
-        source_dir: src/complaint/traces
-        destination_dir: ${{ github.run_id }}/open-bus/complaint
-    - name: output link to report to the trace
-      if: always() && steps.s3-trace.outcome == 'success'
-      run: echo "link to trace - https://trace.playwright.dev/?trace=https://s3.amazonaws.com/noam-gaash.co.il/${{ github.run_id }}/open-bus/complaint/trace.zip" >> $GITHUB_STEP_SUMMARY
+      - uses: actions/checkout@v4
+      - run: npm run docker:build
+        working-directory: src/complaint
+      - run: npm run docker:run
+        working-directory: src/complaint
+      - uses: actions/upload-artifact@v4
+        if: always()
+        with:
+          name: playwright-trace
+          path: src/complaint/traces
+          retention-days: 30\
+      - uses: shallwefootball/s3-upload-action@master
+        name: Upload trace to S3
+        if: always()
+        id: s3-trace
+        continue-on-error: true
+        with:
+          aws_key_id: ${{ secrets.AWS_KEY_ID }}
+          aws_secret_access_key: ${{ secrets.AWS_SECRET_ACCESS_KEY}}
+          aws_bucket: noam-gaash.co.il
+          source_dir: src/complaint/traces
+          destination_dir: ${{ github.run_id }}/open-bus/complaint
+      - name: output link to report to the trace
+        if: always() && steps.s3-trace.outcome == 'success'
+        run: echo "link to trace - https://trace.playwright.dev/?trace=https://s3.amazonaws.com/noam-gaash.co.il/${{ github.run_id }}/open-bus/complaint/trace.zip" >> $GITHUB_STEP_SUMMARY
diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml
@@ -11,13 +11,13 @@ env:
 
 jobs:
   test-with-coverage:
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: Use Node.js
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 20
       - name: Run install
         run: npm ci
       - run: npx playwright install
diff --git a/.github/workflows/deploy-preview.yml b/.github/workflows/deploy-preview.yml
@@ -1,47 +1,47 @@
 on:
-    workflow_run:
-      workflows: ["Build"]
-      types:
-        - completed
-  
+  workflow_run:
+    workflows: ['Build']
+    types:
+      - completed
+
 jobs:
   deploy-to-s3:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
 
       - name: Download dist-build artifact
-        uses: dawidd6/action-download-artifact@v6
+        uses: dawidd6/action-download-artifact@v9
         with:
-            workflow: 'Build'
-            workflow_conclusion: success
-            github_token: ${{ secrets.GITHUB_TOKEN }}
-            run_id: ${{ github.event.workflow_run.id }}
-            run_number: ${{ github.event.workflow_run.run_number }}
-            name: dist-build
-            path: .
+          workflow: 'Build'
+          workflow_conclusion: success
+          github_token: ${{ secrets.GITHUB_TOKEN }}
+          run_id: ${{ github.event.workflow_run.id }}
+          run_number: ${{ github.event.workflow_run.run_number }}
+          name: dist-build
+          path: .
 
       - name: Download dist-storybook artifact
-        uses: dawidd6/action-download-artifact@v6
+        uses: dawidd6/action-download-artifact@v9
         with:
-            workflow: 'Build'
-            workflow_conclusion: success
-            github_token: ${{ secrets.GITHUB_TOKEN }}
-            run_id: ${{ github.event.workflow_run.id }}
-            run_number: ${{ github.event.workflow_run.run_number }}
-            name: dist-storybook
-            path: storybook
+          workflow: 'Build'
+          workflow_conclusion: success
+          github_token: ${{ secrets.GITHUB_TOKEN }}
+          run_id: ${{ github.event.workflow_run.id }}
+          run_number: ${{ github.event.workflow_run.run_number }}
+          name: dist-storybook
+          path: storybook
 
       - name: Download pr number
-        uses: dawidd6/action-download-artifact@v6
+        uses: dawidd6/action-download-artifact@v9
         with:
-            workflow: 'Build'
-            workflow_conclusion: success
-            github_token: ${{ secrets.GITHUB_TOKEN }}
-            run_id: ${{ github.event.workflow_run.id }}
-            run_number: ${{ github.event.workflow_run.run_number }}
-            name: pr_number
-            path: .
+          workflow: 'Build'
+          workflow_conclusion: success
+          github_token: ${{ secrets.GITHUB_TOKEN }}
+          run_id: ${{ github.event.workflow_run.id }}
+          run_number: ${{ github.event.workflow_run.run_number }}
+          name: pr_number
+          path: .
 
       - name: Read PR number
         id: read-pr
@@ -58,11 +58,11 @@ jobs:
           aws_key_id: ${{ secrets.AWS_KEY_ID }}
           aws_secret_access_key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
           aws_bucket: noam-gaash.co.il
-          source_dir: .  # Upload the root directory
+          source_dir: . # Upload the root directory
           destination_dir: ${{ github.event.workflow_run.id }}/open-bus/${{ github.event.workflow_run.run_number }}
 
       - name: find comment
-        uses: peter-evans/find-comment@v1
+        uses: peter-evans/find-comment@v3
         if: env.PR_NUMBER
         id: fc
         with:
@@ -71,7 +71,7 @@ jobs:
           body-includes: 'Preview'
 
       - name: update comment
-        uses: peter-evans/create-or-update-comment@v1
+        uses: peter-evans/create-or-update-comment@v4
         if: steps.fc.outputs.comment-id
         with:
           comment-id: ${{ steps.fc.outputs.comment-id }}
@@ -82,7 +82,7 @@ jobs:
             Test Report (if available): 'https://s3.amazonaws.com/noam-gaash.co.il/${{ github.event.workflow_run.id }}/open-bus/${{ github.event.workflow_run.head_sha }}/test-results/index.html'
 
       - name: create comment
-        uses: peter-evans/create-or-update-comment@v1
+        uses: peter-evans/create-or-update-comment@v4
         if: steps.fc.outputs.comment-id == ''
         with:
           issue-number: ${{ env.PR_NUMBER }}
diff --git a/.github/workflows/docker_test.yml b/.github/workflows/docker_test.yml
@@ -9,9 +9,9 @@ on:
 
 jobs:
   docker-build:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - name: check the dockerfile
         run: |
           docker build .
diff --git a/.github/workflows/validate.yaml b/.github/workflows/validate.yaml
