fix: getAgencyList fallback (#1129)

Author: AvivAbachi

src/api/agencyList.ts

@@ -1,6 +1,7 @@
 import { useEffect, useState } from 'react'
 import moment from 'moment'
 import { BASE_PATH } from './apiConfig'
+
 export interface Agency {
   date: string // example - "2019-07-01"
   operator_ref: number // example - 25,
@@ -9,17 +10,32 @@ export interface Agency {
 
 let agencyList: Agency[]
 
+const tryDates = [
+  moment().subtract(1, 'day').format('YYYY-MM-DD'),
+  moment().subtract(8, 'day').format('YYYY-MM-DD'),
+  '2025-05-18',
+]
+
 /**
  * Fetch agency data from MOT api
  * @returns Agency data array, might contain DUPLICATE agencies with different `date` values
  */
 export default async function getAgencyList(): Promise<Agency[]> {
   if (!agencyList) {
-    const yesterday = moment().subtract(1, 'day').format('YYYY-MM-DD')
-    const response = await fetch(`${BASE_PATH}/gtfs_agencies/list?date_from=${yesterday}`)
-    const data = (await response.json()) as Awaited<Agency[]>
-    agencyList = data.filter(Boolean) // filter empty entries
+    let data: Agency[] = []
+    for (const date of tryDates) {
+      try {
+        const response = await fetch(`${BASE_PATH}/gtfs_agencies/list?date_from=${date}`)
+        if (!response.ok) continue
+        data = (await response.json()) as Agency[]
+        if (data.length > 0) break
+      } catch (err) {
+        console.error(err)
+      }
+    }
+    agencyList = data.filter(Boolean)
   }
+
   return agencyList
 }
 

tests/visual.spec.ts

@@ -96,7 +96,7 @@ test.describe('Visual Tests', () => {
   test('operator page should look good', async ({ page }) => {
     await page.goto('/operator')
     await page.getByRole('combobox', { name: 'חברה מפעילה' }).click()
-    await page.getByRole('option', { name: 'אגד' }).click()
+    await page.getByRole('option', { name: 'אגד', exact: true }).click()
     await waitForSkeletonsToHide(page)
     await eyes.check('operator page', Target.window().layoutRegions('.chart', '.recharts-wrapper'))
   })