fix(ops): use type_error everywhere (denoland#195)

mmastrac · web-flow · commit bae7c42052bd · 2023-09-13T16:05:37.000Z
diff --git a/ops/op2/dispatch_slow.rs b/ops/op2/dispatch_slow.rs
@@ -726,7 +726,7 @@ fn throw_type_error_string(
     #maybe_scope
     // TODO(mmastrac): This might be allocating too much, even if it's on the error path
     let msg = #deno_core::v8::String::new(&mut #scope, &format!("{}", #deno_core::anyhow::Error::from(#message))).unwrap();
-    let exc = #deno_core::v8::Exception::error(&mut #scope, msg);
+    let exc = #deno_core::v8::Exception::type_error(&mut #scope, msg);
     #scope.throw_exception(exc);
     return;
   }))
@@ -746,7 +746,7 @@ fn throw_type_error_static_string(
   Ok(gs_quote!(generator_state(deno_core, scope) => {
     #maybe_scope
     let msg = #deno_core::v8::String::new_from_one_byte(&mut #scope, #message.as_bytes(), #deno_core::v8::NewStringType::Normal).unwrap();
-    let exc = #deno_core::v8::Exception::error(&mut #scope, msg);
+    let exc = #deno_core::v8::Exception::type_error(&mut #scope, msg);
     #scope.throw_exception(exc);
     return;
   }))
diff --git a/ops/op2/test_cases/async/async_jsbuffer.out b/ops/op2/test_cases/async/async_jsbuffer.out
@@ -51,7 +51,7 @@ impl op_async_v8_buffer {
                             deno_core::v8::NewStringType::Normal,
                         )
                         .unwrap();
-                    let exc = deno_core::v8::Exception::error(&mut scope, msg);
+                    let exc = deno_core::v8::Exception::type_error(&mut scope, msg);
                     scope.throw_exception(exc);
                     return;
                 }
@@ -78,7 +78,7 @@ impl op_async_v8_buffer {
                             &format!("{}", deno_core::anyhow::Error::from(rv_err)),
                         )
                         .unwrap();
-                    let exc = deno_core::v8::Exception::error(&mut scope, msg);
+                    let exc = deno_core::v8::Exception::type_error(&mut scope, msg);
                     scope.throw_exception(exc);
                     return;
                 }
diff --git a/ops/op2/test_cases/sync/buffers.out b/ops/op2/test_cases/sync/buffers.out
@@ -75,7 +75,7 @@ impl op_buffers {
                             deno_core::v8::NewStringType::Normal,
                         )
                         .unwrap();
-                    let exc = deno_core::v8::Exception::error(&mut scope, msg);
+                    let exc = deno_core::v8::Exception::type_error(&mut scope, msg);
                     scope.throw_exception(exc);
                     return;
                 }
@@ -96,7 +96,7 @@ impl op_buffers {
                             deno_core::v8::NewStringType::Normal,
                         )
                         .unwrap();
-                    let exc = deno_core::v8::Exception::error(&mut scope, msg);
+                    let exc = deno_core::v8::Exception::type_error(&mut scope, msg);
                     scope.throw_exception(exc);
                     return;
                 }
@@ -164,7 +164,7 @@ impl op_buffers_option {
                                 deno_core::v8::NewStringType::Normal,
                             )
                             .unwrap();
-                        let exc = deno_core::v8::Exception::error(&mut scope, msg);
+                        let exc = deno_core::v8::Exception::type_error(&mut scope, msg);
                         scope.throw_exception(exc);
                         return;
                     }
@@ -190,7 +190,7 @@ impl op_buffers_option {
                                 deno_core::v8::NewStringType::Normal,
                             )
                             .unwrap();
-                        let exc = deno_core::v8::Exception::error(&mut scope, msg);
+                        let exc = deno_core::v8::Exception::type_error(&mut scope, msg);
                         scope.throw_exception(exc);
                         return;
                     }
diff --git a/ops/op2/test_cases/sync/buffers_copy.out b/ops/op2/test_cases/sync/buffers_copy.out
@@ -85,7 +85,7 @@ impl op_buffers {
                             deno_core::v8::NewStringType::Normal,
                         )
                         .unwrap();
-                    let exc = deno_core::v8::Exception::error(&mut scope, msg);
+                    let exc = deno_core::v8::Exception::type_error(&mut scope, msg);
                     scope.throw_exception(exc);
                     return;
                 }
@@ -106,7 +106,7 @@ impl op_buffers {
                             deno_core::v8::NewStringType::Normal,
                         )
                         .unwrap();
-                    let exc = deno_core::v8::Exception::error(&mut scope, msg);
+                    let exc = deno_core::v8::Exception::type_error(&mut scope, msg);
                     scope.throw_exception(exc);
                     return;
                 }
@@ -127,7 +127,7 @@ impl op_buffers {
                             deno_core::v8::NewStringType::Normal,
                         )
                         .unwrap();
-                    let exc = deno_core::v8::Exception::error(&mut scope, msg);
+                    let exc = deno_core::v8::Exception::type_error(&mut scope, msg);
                     scope.throw_exception(exc);
                     return;
                 }
diff --git a/ops/op2/test_cases/sync/serde_v8.out b/ops/op2/test_cases/sync/serde_v8.out
@@ -40,7 +40,7 @@ impl op_serde_v8 {
                             &format!("{}", deno_core::anyhow::Error::from(arg0_err)),
                         )
                         .unwrap();
-                    let exc = deno_core::v8::Exception::error(&mut scope, msg);
+                    let exc = deno_core::v8::Exception::type_error(&mut scope, msg);
                     scope.throw_exception(exc);
                     return;
                 }
@@ -61,7 +61,7 @@ impl op_serde_v8 {
                         &format!("{}", deno_core::anyhow::Error::from(rv_err)),
                     )
                     .unwrap();
-                let exc = deno_core::v8::Exception::error(&mut scope, msg);
+                let exc = deno_core::v8::Exception::type_error(&mut scope, msg);
                 scope.throw_exception(exc);
                 return;
             }
diff --git a/ops/op2/test_cases/sync/string_onebyte.out b/ops/op2/test_cases/sync/string_onebyte.out
@@ -64,7 +64,7 @@ impl op_string_onebyte {
                             deno_core::v8::NewStringType::Normal,
                         )
                         .unwrap();
-                    let exc = deno_core::v8::Exception::error(&mut scope, msg);
+                    let exc = deno_core::v8::Exception::type_error(&mut scope, msg);
                     scope.throw_exception(exc);
                     return;
                 }
diff --git a/ops/op2/test_cases/sync/string_option_return.out b/ops/op2/test_cases/sync/string_option_return.out
@@ -47,7 +47,7 @@ impl op_string_return {
                         &format!("{}", deno_core::anyhow::Error::from(rv_err)),
                     )
                     .unwrap();
-                let exc = deno_core::v8::Exception::error(&mut scope, msg);
+                let exc = deno_core::v8::Exception::type_error(&mut scope, msg);
                 scope.throw_exception(exc);
                 return;
             }
diff --git a/ops/op2/test_cases/sync/string_return.out b/ops/op2/test_cases/sync/string_return.out
@@ -36,7 +36,7 @@ impl op_string_return {
                         &format!("{}", deno_core::anyhow::Error::from(rv_err)),
                     )
                     .unwrap();
-                let exc = deno_core::v8::Exception::error(&mut scope, msg);
+                let exc = deno_core::v8::Exception::type_error(&mut scope, msg);
                 scope.throw_exception(exc);
                 return;
             }
@@ -86,7 +86,7 @@ impl op_string_return_ref {
                         &format!("{}", deno_core::anyhow::Error::from(rv_err)),
                     )
                     .unwrap();
-                let exc = deno_core::v8::Exception::error(&mut scope, msg);
+                let exc = deno_core::v8::Exception::type_error(&mut scope, msg);
                 scope.throw_exception(exc);
                 return;
             }
@@ -136,7 +136,7 @@ impl op_string_return_cow {
                         &format!("{}", deno_core::anyhow::Error::from(rv_err)),
                     )
                     .unwrap();
-                let exc = deno_core::v8::Exception::error(&mut scope, msg);
+                let exc = deno_core::v8::Exception::type_error(&mut scope, msg);
                 scope.throw_exception(exc);
                 return;
             }

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ impl op_async_v8_buffer {`
`51`	`51`	`deno_core::v8::NewStringType::Normal,`
`52`	`52`	`)`
`53`	`53`	`.unwrap();`
`54`		`- let exc = deno_core::v8::Exception::error(&mut scope, msg);`
	`54`	`+ let exc = deno_core::v8::Exception::type_error(&mut scope, msg);`
`55`	`55`	`scope.throw_exception(exc);`
`56`	`56`	`return;`
`57`	`57`	`}`
`@@ -78,7 +78,7 @@ impl op_async_v8_buffer {`
`78`	`78`	`&format!("{}", deno_core::anyhow::Error::from(rv_err)),`
`79`	`79`	`)`
`80`	`80`	`.unwrap();`
`81`		`- let exc = deno_core::v8::Exception::error(&mut scope, msg);`
	`81`	`+ let exc = deno_core::v8::Exception::type_error(&mut scope, msg);`
`82`	`82`	`scope.throw_exception(exc);`
`83`	`83`	`return;`
`84`	`84`	`}`
Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ impl op_buffers {`
`75`	`75`	`deno_core::v8::NewStringType::Normal,`
`76`	`76`	`)`
`77`	`77`	`.unwrap();`
`78`		`- let exc = deno_core::v8::Exception::error(&mut scope, msg);`
	`78`	`+ let exc = deno_core::v8::Exception::type_error(&mut scope, msg);`
`79`	`79`	`scope.throw_exception(exc);`
`80`	`80`	`return;`
`81`	`81`	`}`
`@@ -96,7 +96,7 @@ impl op_buffers {`
`96`	`96`	`deno_core::v8::NewStringType::Normal,`
`97`	`97`	`)`
`98`	`98`	`.unwrap();`
`99`		`- let exc = deno_core::v8::Exception::error(&mut scope, msg);`
	`99`	`+ let exc = deno_core::v8::Exception::type_error(&mut scope, msg);`
`100`	`100`	`scope.throw_exception(exc);`
`101`	`101`	`return;`
`102`	`102`	`}`
`@@ -164,7 +164,7 @@ impl op_buffers_option {`
`164`	`164`	`deno_core::v8::NewStringType::Normal,`
`165`	`165`	`)`
`166`	`166`	`.unwrap();`
`167`		`- let exc = deno_core::v8::Exception::error(&mut scope, msg);`
	`167`	`+ let exc = deno_core::v8::Exception::type_error(&mut scope, msg);`
`168`	`168`	`scope.throw_exception(exc);`
`169`	`169`	`return;`
`170`	`170`	`}`
`@@ -190,7 +190,7 @@ impl op_buffers_option {`
`190`	`190`	`deno_core::v8::NewStringType::Normal,`
`191`	`191`	`)`
`192`	`192`	`.unwrap();`
`193`		`- let exc = deno_core::v8::Exception::error(&mut scope, msg);`
	`193`	`+ let exc = deno_core::v8::Exception::type_error(&mut scope, msg);`
`194`	`194`	`scope.throw_exception(exc);`
`195`	`195`	`return;`
`196`	`196`	`}`
Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ impl op_buffers {`
`85`	`85`	`deno_core::v8::NewStringType::Normal,`
`86`	`86`	`)`
`87`	`87`	`.unwrap();`
`88`		`- let exc = deno_core::v8::Exception::error(&mut scope, msg);`
	`88`	`+ let exc = deno_core::v8::Exception::type_error(&mut scope, msg);`
`89`	`89`	`scope.throw_exception(exc);`
`90`	`90`	`return;`
`91`	`91`	`}`
`@@ -106,7 +106,7 @@ impl op_buffers {`
`106`	`106`	`deno_core::v8::NewStringType::Normal,`
`107`	`107`	`)`
`108`	`108`	`.unwrap();`
`109`		`- let exc = deno_core::v8::Exception::error(&mut scope, msg);`
	`109`	`+ let exc = deno_core::v8::Exception::type_error(&mut scope, msg);`
`110`	`110`	`scope.throw_exception(exc);`
`111`	`111`	`return;`
`112`	`112`	`}`
`@@ -127,7 +127,7 @@ impl op_buffers {`
`127`	`127`	`deno_core::v8::NewStringType::Normal,`
`128`	`128`	`)`
`129`	`129`	`.unwrap();`
`130`		`- let exc = deno_core::v8::Exception::error(&mut scope, msg);`
	`130`	`+ let exc = deno_core::v8::Exception::type_error(&mut scope, msg);`
`131`	`131`	`scope.throw_exception(exc);`
`132`	`132`	`return;`
`133`	`133`	`}`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ impl op_serde_v8 {`
`40`	`40`	`&format!("{}", deno_core::anyhow::Error::from(arg0_err)),`
`41`	`41`	`)`
`42`	`42`	`.unwrap();`
`43`		`- let exc = deno_core::v8::Exception::error(&mut scope, msg);`
	`43`	`+ let exc = deno_core::v8::Exception::type_error(&mut scope, msg);`
`44`	`44`	`scope.throw_exception(exc);`
`45`	`45`	`return;`
`46`	`46`	`}`
`@@ -61,7 +61,7 @@ impl op_serde_v8 {`
`61`	`61`	`&format!("{}", deno_core::anyhow::Error::from(rv_err)),`
`62`	`62`	`)`
`63`	`63`	`.unwrap();`
`64`		`- let exc = deno_core::v8::Exception::error(&mut scope, msg);`
	`64`	`+ let exc = deno_core::v8::Exception::type_error(&mut scope, msg);`
`65`	`65`	`scope.throw_exception(exc);`
`66`	`66`	`return;`
`67`	`67`	`}`
Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ impl op_string_onebyte {`
`64`	`64`	`deno_core::v8::NewStringType::Normal,`
`65`	`65`	`)`
`66`	`66`	`.unwrap();`
`67`		`- let exc = deno_core::v8::Exception::error(&mut scope, msg);`
	`67`	`+ let exc = deno_core::v8::Exception::type_error(&mut scope, msg);`
`68`	`68`	`scope.throw_exception(exc);`
`69`	`69`	`return;`
`70`	`70`	`}`
Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ impl op_string_return {`
`47`	`47`	`&format!("{}", deno_core::anyhow::Error::from(rv_err)),`
`48`	`48`	`)`
`49`	`49`	`.unwrap();`
`50`		`- let exc = deno_core::v8::Exception::error(&mut scope, msg);`
	`50`	`+ let exc = deno_core::v8::Exception::type_error(&mut scope, msg);`
`51`	`51`	`scope.throw_exception(exc);`
`52`	`52`	`return;`
`53`	`53`	`}`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ impl op_string_return {`
`36`	`36`	`&format!("{}", deno_core::anyhow::Error::from(rv_err)),`
`37`	`37`	`)`
`38`	`38`	`.unwrap();`
`39`		`- let exc = deno_core::v8::Exception::error(&mut scope, msg);`
	`39`	`+ let exc = deno_core::v8::Exception::type_error(&mut scope, msg);`
`40`	`40`	`scope.throw_exception(exc);`
`41`	`41`	`return;`
`42`	`42`	`}`
`@@ -86,7 +86,7 @@ impl op_string_return_ref {`
`86`	`86`	`&format!("{}", deno_core::anyhow::Error::from(rv_err)),`
`87`	`87`	`)`
`88`	`88`	`.unwrap();`
`89`		`- let exc = deno_core::v8::Exception::error(&mut scope, msg);`
	`89`	`+ let exc = deno_core::v8::Exception::type_error(&mut scope, msg);`
`90`	`90`	`scope.throw_exception(exc);`
`91`	`91`	`return;`
`92`	`92`	`}`
`@@ -136,7 +136,7 @@ impl op_string_return_cow {`
`136`	`136`	`&format!("{}", deno_core::anyhow::Error::from(rv_err)),`
`137`	`137`	`)`
`138`	`138`	`.unwrap();`
`139`		`- let exc = deno_core::v8::Exception::error(&mut scope, msg);`
	`139`	`+ let exc = deno_core::v8::Exception::type_error(&mut scope, msg);`
`140`	`140`	`scope.throw_exception(exc);`
`141`	`141`	`return;`
`142`	`142`	`}`