Strict parser. Closes #39

Author: hueniverse

lib/index.js

@@ -18,14 +18,23 @@ internals.Range = class {
 };
 
 
+// RFC 7233 (https://tools.ietf.org/html/rfc7233#appendix-D)
+//
+// Range = "bytes" "=" byte-range-set
+// byte-range-set = *( "," OWS ) byte-range-spec *( OWS "," [ OWS byte-range-spec ] )
+// byte-range-spec = ( 1*DIGIT "-" [ 1*DIGIT ] ) / ( "-" 1*DIGIT )
+
+
+//                                12  3          3 4       425         6  7          7 8       865 1
+internals.headerRx = /^bytes=[\s,]*((?:(?:\d+\-\d*)|(?:\-\d+))(?:\s*,\s*(?:(?:\d+\-\d*)|(?:\-\d+)))*)$/i;
+
+
 exports.header = function (header, length) {
 
     // Parse header
 
-    const parts = header.split('=');
-    if (parts.length !== 2 ||
-        parts[0] !== 'bytes') {
-
+    const parts = internals.headerRx.exec(header);
+    if (!parts) {
         return null;
     }
 
@@ -36,12 +45,7 @@ exports.header = function (header, length) {
 
     // Handle headers with multiple ranges
 
-    for (let i = 0; i < ranges.length; ++i) {
-        let range = ranges[i];
-        if (range.length === 1) {               // '-'
-            return null;
-        }
-
+    for (let range of ranges) {
         let from;
         let to;
         range = range.split('-');