Skip to content

Commit d2687c5

Browse files
committed
Make second parameter of "log" method optional on iOS
1 parent c5ea514 commit d2687c5

File tree

3 files changed

+11
-10
lines changed

3 files changed

+11
-10
lines changed

ios/Classes/FirebaseAnalyticsModule.m

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,11 @@ - (void)configure:(id)arguments
5151

5252
- (void)log:(id)arguments
5353
{
54-
ENSURE_ARG_COUNT(arguments, 2);
54+
NSString *name = nil;
55+
NSDictionary *parameters = nil;
5556

56-
NSString *name = [arguments objectAtIndex:0];
57-
NSDictionary *parameters = [arguments objectAtIndex:1];
57+
ENSURE_ARG_AT_INDEX(name, arguments, 0, NSString);
58+
ENSURE_ARG_OR_NIL_AT_INDEX(parameters, arguments, 1, NSDictionary);
5859

5960
[FIRAnalytics logEventWithName:name
6061
parameters:parameters];

ios/Classes/FirebaseAnalyticsModuleAssets.m

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,18 +7,18 @@
77

88
@implementation FirebaseAnalyticsModuleAssets
99

10-
- (NSData*) moduleAsset
10+
- (NSData *)moduleAsset
1111
{
12-
12+
1313

14-
return nil;
14+
return nil;
1515
}
1616

17-
- (NSData*) resolveModuleAsset:(NSString*)path
17+
- (NSData *)resolveModuleAsset:(NSString *)path
1818
{
19-
19+
2020

21-
return nil;
21+
return nil;
2222
}
2323

2424
@end

ios/manifest

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# this is your module manifest and used by Titanium
33
# during compilation, packaging, distribution, etc.
44
#
5-
version: 1.1.0
5+
version: 1.1.1
66
apiversion: 2
77
architectures: armv7 arm64 i386 x86_64
88
description: titanium-firebase-analytics

0 commit comments

Comments
 (0)