Skip to content

Commit 1529d47

Browse files
committed
Merge remote-tracking branch 'upstream/pr/12562' into develop
* upstream/pr/12562: Preselect core namespace if it is available in namespace combo box
2 parents 0fc85b2 + 589ef9a commit 1529d47

File tree

3 files changed

+12
-4
lines changed

3 files changed

+12
-4
lines changed

core/docs/changelog.txt

+1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ development release, and is only shown to give an idea of what's currently in th
44

55
MODX Revolution 2.4.0-dev
66
====================================
7+
- Preselect core namespace if it is available in namespace combo box [#12562]
78
- Fix namespace and policy filter in namespace access grid [#12560]
89
- Escape Site name in header
910
- Fix double nocompress option in advanced install

manager/assets/modext/widgets/core/modx.combo.js

+9-2
Original file line numberDiff line numberDiff line change
@@ -639,12 +639,19 @@ MODx.combo.Namespace = function(config) {
639639
Ext.extend(MODx.combo.Namespace,MODx.combo.ComboBox, {
640640
preselectFirstValue: function(r) {
641641
var item;
642+
642643
if (this.config.preselectValue == '') {
643644
item = r.getAt(0);
644645
} else {
645-
item = {data: {name: this.config.preselectValue}};
646+
var found = r.find('name', this.config.preselectValue);
647+
648+
if (found != -1) {
649+
item = r.getAt(found);
650+
} else {
651+
item = r.getAt(0);
652+
}
646653
}
647-
654+
648655
if (item) {
649656
this.setValue(item.data.name);
650657
this.fireEvent('select', this, item);

manager/assets/modext/widgets/core/modx.grid.settings.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ MODx.grid.SettingsGrid = function(config) {
2323
,name: 'namespace'
2424
,id: 'modx-filter-namespace'
2525
,emptyText: _('namespace_filter')
26-
,preselectValue: MODx.request['ns'] ? MODx.request['ns'] : ''
26+
,preselectValue: MODx.request['ns'] ? MODx.request['ns'] : 'core'
2727
,allowBlank: false
2828
,editable: true
2929
,typeAhead: true
@@ -138,7 +138,7 @@ MODx.grid.SettingsGrid = function(config) {
138138
,url: MODx.config.connector_url
139139
,baseParams: {
140140
action: 'system/settings/getList'
141-
,namespace: MODx.request['ns'] ? MODx.request['ns'] : ''
141+
,namespace: MODx.request['ns'] ? MODx.request['ns'] : 'core'
142142
,area: MODx.request['area']
143143
}
144144
,clicksToEdit: 2

0 commit comments

Comments
 (0)