Skip to content

Commit 74b2dca

Browse files
committed
Query: add exemplar.partial-response flag to control partial response (thanos-io#4676)
Signed-off-by: hanjm <[email protected]>
1 parent a641207 commit 74b2dca

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

cmd/thanos/query.go

+6
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,9 @@ func registerQuery(app *extkingpin.App) {
146146
enableMetricMetadataPartialResponse := cmd.Flag("metric-metadata.partial-response", "Enable partial response for metric metadata endpoint. --no-metric-metadata.partial-response for disabling.").
147147
Hidden().Default("true").Bool()
148148

149+
enableExemplarPartialResponse := cmd.Flag("exemplar.partial-response", "Enable partial response for exemplar endpoint. --no-exemplar.partial-response for disabling.").
150+
Hidden().Default("true").Bool()
151+
149152
defaultEvaluationInterval := extkingpin.ModelDuration(cmd.Flag("query.default-evaluation-interval", "Set default evaluation interval for sub queries.").Default("1m"))
150153

151154
defaultRangeQueryStep := extkingpin.ModelDuration(cmd.Flag("query.default-step", "Set default step for range queries. Default step is only used when step is not set in UI. In such cases, Thanos UI will use default step to calculate resolution (resolution = max(rangeSeconds / 250, defaultStep)). This will not work from Grafana, but Grafana has __step variable which can be used.").
@@ -254,6 +257,7 @@ func registerQuery(app *extkingpin.App) {
254257
*enableRulePartialResponse,
255258
*enableTargetPartialResponse,
256259
*enableMetricMetadataPartialResponse,
260+
*enableExemplarPartialResponse,
257261
fileSD,
258262
time.Duration(*dnsSDInterval),
259263
*dnsSDResolver,
@@ -316,6 +320,7 @@ func runQuery(
316320
enableRulePartialResponse bool,
317321
enableTargetPartialResponse bool,
318322
enableMetricMetadataPartialResponse bool,
323+
enableExemplarPartialResponse bool,
319324
fileSD *file.Discovery,
320325
dnsSDInterval time.Duration,
321326
dnsSDResolver string,
@@ -554,6 +559,7 @@ func runQuery(
554559
enableRulePartialResponse,
555560
enableTargetPartialResponse,
556561
enableMetricMetadataPartialResponse,
562+
enableExemplarPartialResponse,
557563
queryReplicaLabels,
558564
flagsMap,
559565
defaultRangeQueryStep,

pkg/api/query/v1.go

+2
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,7 @@ func NewQueryAPI(
118118
enableRulePartialResponse bool,
119119
enableTargetPartialResponse bool,
120120
enableMetricMetadataPartialResponse bool,
121+
enableExemplarPartialResponse bool,
121122
replicaLabels []string,
122123
flagsMap map[string]string,
123124
defaultRangeQueryStep time.Duration,
@@ -143,6 +144,7 @@ func NewQueryAPI(
143144
enableRulePartialResponse: enableRulePartialResponse,
144145
enableTargetPartialResponse: enableTargetPartialResponse,
145146
enableMetricMetadataPartialResponse: enableMetricMetadataPartialResponse,
147+
enableExemplarPartialResponse: enableExemplarPartialResponse,
146148
replicaLabels: replicaLabels,
147149
endpointSet: endpointSet,
148150
defaultRangeQueryStep: defaultRangeQueryStep,

0 commit comments

Comments
 (0)