Skip to content

Commit 7887ef6

Browse files
authored
chore: fix failing UI unit tests (#2221)
1 parent a0151cd commit 7887ef6

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

ui/src/combobox.test.tsx

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -56,15 +56,15 @@ describe('Combobox.tsx', () => {
5656
})
5757

5858
it('Adds new typed option only once to options list', () => {
59-
const { getAllByRole, getByRole, queryAllByTitle, } = render(<XCombobox model={{ ...comboboxProps, value: 'A' }} />)
59+
const { getAllByRole, getByRole, queryAllByText } = render(<XCombobox model={{ ...comboboxProps, value: 'A' }} />)
6060
fireEvent.click(getByRole('presentation', { hidden: true }))
6161
expect(getAllByRole('option')).toHaveLength(3)
62-
expect(queryAllByTitle('D')).toHaveLength(0)
62+
expect(queryAllByText('D')).toHaveLength(0)
6363

6464
userEvent.type(getByRole('combobox'), '{backspace}D{enter}')
6565
fireEvent.click(getByRole('presentation', { hidden: true }))
6666
expect(getAllByRole('option')).toHaveLength(4)
67-
expect(queryAllByTitle('D')).toHaveLength(1)
67+
expect(queryAllByText('D')).toHaveLength(1)
6868
})
6969

7070
describe('Wave args', () => {
@@ -78,13 +78,13 @@ describe('Combobox.tsx', () => {
7878
})
7979

8080
it('Sets args to manually selected option', () => {
81-
const { getByRole, getByTitle } = render(<XCombobox model={{ ...comboboxProps }} />)
81+
const { getByRole, getByText } = render(<XCombobox model={{ ...comboboxProps }} />)
8282
fireEvent.click(getByRole('presentation', { hidden: true }))
83-
fireEvent.click(getByTitle('A'))
83+
fireEvent.click(getByText('A'))
8484
expect(wave.args[name]).toBe('A')
8585

8686
fireEvent.click(getByRole('presentation', { hidden: true }))
87-
fireEvent.click(getByTitle('B'))
87+
fireEvent.click(getByText('B'))
8888
expect(wave.args[name]).toBe('B')
8989
})
9090

@@ -206,23 +206,23 @@ describe('Combobox.tsx', () => {
206206
})
207207

208208
it('Adds initial value to options if it\'s not included in "choices" prop', () => {
209-
const { getByTitle, getAllByRole, getByRole } = render(<XCombobox model={{ ...comboboxProps, value: 'Z' }} />)
209+
const { getByText, getAllByRole, getByRole } = render(<XCombobox model={{ ...comboboxProps, value: 'Z' }} />)
210210
expect(wave.args[name]).toEqual('Z')
211211
expect(getByRole('combobox')).toHaveValue('Z')
212212
fireEvent.click(getByRole('presentation', { hidden: true }))
213213
expect(getAllByRole('option')).toHaveLength(4)
214-
expect(getByTitle('Z')).toBeDefined()
214+
expect(getByText('Z')).toBeDefined()
215215
})
216216

217217
it('Adds value to choices when both are updated and value was included in previous choices but not in the new choices', () => {
218-
const { getByRole, getAllByRole, getByTitle, rerender } = render(<XCombobox model={{ ...comboboxProps, value: 'A' }} />)
218+
const { getByRole, getAllByRole, getByText, rerender } = render(<XCombobox model={{ ...comboboxProps, value: 'A' }} />)
219219
expect(getByRole('combobox')).toHaveValue('A')
220220

221221
rerender(<XCombobox model={{ ...comboboxProps, value: 'C', choices: ['A', 'B'] }} />)
222222
expect(getByRole('combobox')).toHaveValue('C')
223223
fireEvent.click(getByRole('presentation', { hidden: true }))
224224
expect(getAllByRole('option')).toHaveLength(3)
225-
expect(getByTitle('C')).toBeDefined()
225+
expect(getByText('C')).toBeDefined()
226226
})
227227

228228
it('Display same value if choices change and value is included in choices', () => {
@@ -324,12 +324,12 @@ describe('Combobox.tsx', () => {
324324
})
325325

326326
it('Adds initial values to options if they are not already included in options ', () => {
327-
const { getByTitle, getAllByRole, getByRole } = render(<XCombobox model={{ ...comboboxProps, value: 'Z' }} />)
327+
const { getByText, getAllByRole, getByRole } = render(<XCombobox model={{ ...comboboxProps, value: 'Z' }} />)
328328
expect(wave.args[name]).toEqual('Z')
329329
expect(getByRole('combobox')).toHaveValue('Z')
330330
fireEvent.click(getByRole('presentation', { hidden: true }))
331331
expect(getAllByRole('option')).toHaveLength(4)
332-
expect(getByTitle('Z')).toBeDefined()
332+
expect(getByText('Z')).toBeDefined()
333333
})
334334
})
335335
})

0 commit comments

Comments
 (0)