fixes igniterealtime#139: Refactor: remove unused code from PersistenceManager

PersistenceManager had a lot of definition that wasn't used. It either had no implementation, or the little implementation that was there, went unreferenced. This commit removes it all, reducing code complexity by a significant factor.

It appears to me that all removed code was replaced by code in the implementation of ConversationManager - although I'm not 100% sure.

Author: guusdk

src/java/com/reucon/openfire/plugin/archive/PersistenceManager.java

@@ -2,63 +2,18 @@
 
 import com.reucon.openfire.plugin.archive.model.ArchivedMessage;
 import com.reucon.openfire.plugin.archive.model.Conversation;
-import com.reucon.openfire.plugin.archive.model.Participant;
 import com.reucon.openfire.plugin.archive.xep0059.XmppResultSet;
 import org.jivesoftware.util.NotFoundException;
 import org.xmpp.packet.JID;
 
 import java.util.Collection;
 import java.util.Date;
-import java.util.List;
 
 /**
  * Manages database persistence.
  */
 public interface PersistenceManager
 {
-    /**
-     * Creates a new archived message.
-     *
-     * @param message the message to create.
-     * @return <code>true</code> on success, <code>false</code> otherwise.
-     */
-    boolean createMessage(ArchivedMessage message);
-
-    /**
-     * Selects all messages and passes each message to the given callback for processing.
-     *
-     * @param callback callback to process messages.
-     * @return number of messages processed.
-     */
-    int processAllMessages(ArchivedMessageConsumer callback);
-
-    /**
-     * Creates a new conversation.
-     *
-     * @param conversation the conversation to create.
-     * @return <code>true</code> on success, <code>false</code> otherwise.
-     */
-    boolean createConversation(Conversation conversation);
-
-    /**
-     * Updates the end time of a conversation. The conversation must be persisted.
-     *
-     * @param conversation conversation to update with id and endDate attributes not null.
-     * @return <code>true</code> on success, <code>false</code> otherwise.
-     */
-    boolean updateConversationEnd(Conversation conversation);
-
-    /**
-     * Adds a new participant to a conversation.
-     *
-     * @param participant    the participant to add.
-     * @param conversationId id of the conversation to add the participant to.
-     * @return <code>true</code> on success, <code>false</code> otherwise.
-     */
-    boolean createParticipant(Participant participant, Long conversationId);
-
-    List<Conversation> findConversations(String[] participants, Date startDate, Date endDate);
-
     /**
      * Searches for conversations.
      *
@@ -85,10 +40,6 @@ public interface PersistenceManager
      */
     Collection<ArchivedMessage> findMessages( Date startDate, Date endDate, JID owner, JID with, String query, XmppResultSet xmppResultSet, boolean useStableID) throws NotFoundException;
 
-    Collection<Conversation> getActiveConversations(int conversationTimeout);
-
-    List<Conversation> getConversations(Collection<Long> conversationIds);
-
     /**
      * Returns the conversation with the given owner, with and start time including participants and messages.
      *
@@ -97,13 +48,5 @@ public interface PersistenceManager
      * @param start    exact start time
      * @return the matching conversation or <code>null</code> if none matches.
      */
-    Conversation getConversation(JID owner, JID with, Date start);
-
-    /**
-     * Returns the conversation with the given id including participants and messages.
-     *
-     * @param conversationId id of the conversation to retrieve.
-     * @return the matching conversation or <code>null</code> if none matches.
-     */
-    Conversation getConversation(Long conversationId);
+    Conversation getConversation(JID owner, JID with, Date start); // TODO move to ConversationManager?
 }