Skip to content

Commit cc1a3b7

Browse files
committed
v0.1.140 Removed dataOrig and dataMod from flags result - had to change filtering function
1 parent c7f4fd4 commit cc1a3b7

File tree

6 files changed

+10
-20
lines changed

6 files changed

+10
-20
lines changed

DESCRIPTION

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
Package: bdchecks
22
Title: Biodiversity Data Checks
33
Description: Supplies a set of functions to perform and manage data checks for biodiversity data.
4-
Version: 0.1.137
5-
Date: 2019-12-24
4+
Version: 0.1.140
5+
Date: 2020-01-01
66
License: GPL-3 | file LICENSE
77
URL: https://github.com/bd-R/bdchecks
88
BugReports: https://github.com/bd-R/bdchecks/issues

R/classes_generics_methods.R

+1-8
Original file line numberDiff line numberDiff line change
@@ -88,17 +88,10 @@ DataCheckFlag <- setClass(
8888
#'
8989
#' @slot DC names of performed data checks
9090
#' @slot flags list of performed data checks in a DataCheckFlagSet class
91-
#' @slot dataOrig original data before data checks
92-
#' @slot dataMod modified data after data checks
9391
#'
9492
DataCheckFlagSet <- setClass(
9593
"DataCheckFlagSet",
96-
slots = c(
97-
DC = "vector",
98-
flags = "list",
99-
dataOrig = "data.frame",
100-
dataMod = "data.frame"
101-
)
94+
slots = c(DC = "vector", flags = "list")
10295
)
10396

10497
#' Show method for DataCheckFlagSet objects

R/filter.R

+3-2
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,14 @@ dc_filter_generate <- function(dc_result_summary,
3737
#' `dc_filter()` is a function that filters data check result according
3838
#' to filtering vector.
3939
#'
40+
#' @param data Data set on which data checks where performed
4041
#' @param dc_result Object of a DataCheckFlagSet generated with `perforDataCheck()`
4142
#' @param dc_filts A list containing filtering targets and status generated with
4243
#' `dc_filter_generate()`
4344
#'
4445
#' @return A data.frame that is filtered according to given vector
4546
#'
46-
dc_filter <- function(dc_result, dc_filts) {
47+
dc_filter <- function(data, dc_result, dc_filts) {
4748
idx <- c()
4849
names <- sapply(dc_result@flags, function(x) `@`(x, name))
4950
targets <- sapply(dc_result@flags, function(x) `@`(x, target))
@@ -68,5 +69,5 @@ dc_filter <- function(dc_result, dc_filts) {
6869
}
6970
}
7071
idx <- unique(idx)
71-
return(dc_result@dataMod[-idx, ])
72+
return(data[-idx, ])
7273
}

R/perform.R

+1-3
Original file line numberDiff line numberDiff line change
@@ -79,9 +79,7 @@ perform_dc <- function(data = NULL, wanted_dc = NULL) {
7979
if (length(result_dc) > 0) {
8080
result_dc <- methods::new("DataCheckFlagSet",
8181
DC = as.character(lapply(result_dc, function(x) `@`(x, name))),
82-
flags = result_dc,
83-
dataOrig = data,
84-
dataMod = data
82+
flags = result_dc
8583
)
8684
return(result_dc)
8785
} else {

man/DataCheckFlagSet-class.Rd

-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/dc_filter.Rd

+3-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)