Skip to content

API Proposal - Client Interceptors #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rogchap opened this issue May 9, 2019 · 6 comments
Closed

API Proposal - Client Interceptors #555

rogchap opened this issue May 9, 2019 · 6 comments

Comments

@rogchap
Copy link
Contributor

rogchap commented May 9, 2019

gRPC-Web Client Interceptors

Proposal move to #558
Previous description removed to avoid confusion

@stanley-cheung
Copy link
Collaborator

@rogchap This is a great start! Thanks for making this big effort to get this feature started.

Community, and users of gRPC-Web: please also review this to see if you have any feedback to the API design. Many people have asked about this before. Now is the time to speak up.

@Yannic
Copy link
Contributor

Yannic commented May 10, 2019

This is amazing! Thanks for working on this!

I'll have a closer look at the proposed API next week, but it seems like this is a very good start.
In the meantime, it might be easier to have this as a PR so we can use the review feature to discuss specific parts of the proposal (proposals/interceptors.md?).

@stanley-cheung
Copy link
Collaborator

stanley-cheung commented May 10, 2019

Yes, agreed. Having a PR with a .md file can facilitate discussion. We can do this similarly to other gRPC RFCs by making a PR in this repo: https://github.com/grpc/proposal/pulls. Node.JS, Python, PHP, Ruby, C# Interceptors proposal all graduated from there. So browser/web can be next.

@rogchap
Copy link
Contributor Author

rogchap commented May 10, 2019

Easily done; I have the .md file of my original write up on disk.

Wasn't sure where to submit to get the best visibility for the community; if the gRPC/proposal repo is the right one I'll submit a PR there

@stanley-cheung
Copy link
Collaborator

I think we can do it two phases: first we can get one PR here in this repo, then with enough review/revision, we can do one over at grpc/proposal for formality.

@rogchap
Copy link
Contributor Author

rogchap commented May 11, 2019

@stanley-cheung @Yannic Moving this to #558

@rogchap rogchap closed this as completed May 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants