Merge pull request #2761 from brendan-myers/url-encoding

murgatroid99 · web-flow · commit c447875796c7 · 2024-06-18T15:36:48.000-07:00
fix: add decoding for url encoded user credentials
diff --git a/packages/grpc-js/src/http_proxy.ts b/packages/grpc-js/src/http_proxy.ts
@@ -80,7 +80,7 @@ function getProxyInfo(): ProxyInfo {
   if (proxyUrl.username) {
     if (proxyUrl.password) {
       log(LogVerbosity.INFO, 'userinfo found in proxy URI');
-      userCred = `${proxyUrl.username}:${proxyUrl.password}`;
+      userCred = decodeURIComponent(`${proxyUrl.username}:${proxyUrl.password}`);
     } else {
       userCred = proxyUrl.username;
     }

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ function getProxyInfo(): ProxyInfo {`
`80`	`80`	`if (proxyUrl.username) {`
`81`	`81`	`if (proxyUrl.password) {`
`82`	`82`	`log(LogVerbosity.INFO, 'userinfo found in proxy URI');`
`83`		- userCred = `${proxyUrl.username}:${proxyUrl.password}`;
	`83`	+ userCred = decodeURIComponent(`${proxyUrl.username}:${proxyUrl.password}`);
`84`	`84`	`} else {`
`85`	`85`	`userCred = proxyUrl.username;`
`86`	`86`	`}`