Skip to content

Document grpc-netty-shaded in Troubleshooting guide #4103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
saturnism opened this issue Feb 20, 2018 · 7 comments
Closed

Document grpc-netty-shaded in Troubleshooting guide #4103

saturnism opened this issue Feb 20, 2018 · 7 comments
Labels
Milestone

Comments

@saturnism
Copy link
Contributor

saturnism commented Feb 20, 2018

Please answer these questions before submitting your issue.

What version of gRPC are you using?

1.9

What did you expect to see?

Troubleshooting guide should also reference to grpc-netty-shaded for gRPC 1.9+

Also, add additional info re: #4163

@carl-mastrangelo carl-mastrangelo added this to the Unscheduled milestone Feb 23, 2018
@carl-mastrangelo
Copy link
Contributor

@saturnism Are you taking this on?

@saturnism
Copy link
Contributor Author

Yeah I'm working on a PR. What should we say if the user is on an unsupported platform, e.g., 32-bit Windows? Are there options at all? Thanks,

@carl-mastrangelo
Copy link
Contributor

I think we still build the windows x86_32 protoc plugin. For java at least, that's the only windows specific portion.

Also, unsupported doesn't mean it doesn't work, it just means we can't easily test it. Several users have used grpc on on platforms (mips devices for instance). We accept patches by them if they get it to work, but again, this is best effort.

@saturnism
Copy link
Contributor Author

@carl-mastrangelo tcnative doesn't have 32bit builds. is the recommendation to:

  • build your own tcnative
  • use Netty ALPN?

@saturnism
Copy link
Contributor Author

saturnism commented Mar 6, 2018

quick ping. if there are no recommended options, then we'll make it clear in the doc too. Thanks!

@carl-mastrangelo
Copy link
Contributor

@saturnism I think we should make it clear that 32 bit windows should use jetty ALPN, or compile netty_tcnative themselves. It would be too much effort to get 32bit windows builds for netty_tcnative.

@saturnism
Copy link
Contributor Author

Thanks, I'll make that clear in the update!

@ejona86 ejona86 modified the milestones: Unscheduled, 1.12 Aug 17, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Nov 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants