Skip to content

Commit 92b4fae

Browse files
Pass interop parameters to each langs run.sh as-is. run.sh should just pass through to the interop client/server binaries (#10042)
Co-authored-by: Stanley Cheung <[email protected]>
1 parent 1bf518a commit 92b4fae

File tree

1 file changed

+4
-19
lines changed
  • buildscripts/observability-test

1 file changed

+4
-19
lines changed

buildscripts/observability-test/run.sh

+4-19
Original file line numberDiff line numberDiff line change
@@ -16,29 +16,14 @@
1616
set -ex
1717
cd "$(dirname "$0")"/../..
1818

19-
# TODO(stanleycheung): replace positional parameters with explicit parameters
20-
#
21-
# $1: server | client
22-
#
23-
# For server: $2: server_port
24-
#
25-
# For client: $2: server_host
26-
# $3: server_port
27-
# $4: test_case
28-
# $5: num_times
29-
3019
if [ "$1" = "server" ] ; then
31-
/grpc-java/bin/gcp-observability-interop \
32-
server --use_tls=false \
33-
--port=$2
20+
/grpc-java/bin/gcp-observability-interop server --use_tls=false "${@:2}"
3421

3522
elif [ "$1" = "client" ] ; then
36-
/grpc-java/bin/gcp-observability-interop \
37-
client --use_tls=false \
38-
--server_host=$2 --server_port=$3 \
39-
--test_case=$4 --num_times=$5
23+
/grpc-java/bin/gcp-observability-interop client --use_tls=false "${@:2}"
4024

4125
else
42-
echo "Invalid action: $1"
26+
echo "Invalid action: $1. Usage:"
27+
echo " $ .../run.sh [server|client] --server_host=<hostname> --server_port=<port> ..."
4328
exit 1
4429
fi

0 commit comments

Comments
 (0)