xds: emit resource-not-found logs at Warning level (#8158)

Author: easwars

xds/internal/balancer/cdsbalancer/cdsbalancer.go

@@ -572,6 +572,7 @@ func (b *cdsBalancer) onClusterError(name string, err error) {
 //
 // Only executed in the context of a serializer callback.
 func (b *cdsBalancer) onClusterResourceNotFound(name string) {
+	b.logger.Warningf("CDS watch for resource %q reported resource-does-not-exist error", name)
 	err := b.annotateErrorWithNodeID(xdsresource.NewErrorf(xdsresource.ErrorTypeResourceNotFound, "cluster %q not found", name))
 	b.closeChildPolicyAndReportTF(err)
 }

xds/internal/balancer/clusterresolver/resource_resolver_eds.go

@@ -126,9 +126,7 @@ func (er *edsDiscoveryMechanism) OnResourceDoesNotExist(onDone xdsresource.OnDon
 		return
 	}
 
-	if er.logger.V(2) {
-		er.logger.Infof("EDS discovery mechanism for resource %q reported resource-does-not-exist error", er.nameToWatch)
-	}
+	er.logger.Warningf("EDS discovery mechanism for resource %q reported resource-does-not-exist error", er.nameToWatch)
 
 	// Report an empty update that would result in no priority child being
 	// created for this discovery mechanism. This would result in the priority

xds/internal/resolver/xds_resolver.go

@@ -555,12 +555,9 @@ func (r *xdsResolver) onListenerResourceError(err error) {
 
 // Only executed in the context of a serializer callback.
 func (r *xdsResolver) onListenerResourceNotFound() {
-	if r.logger.V(2) {
-		r.logger.Infof("Received resource-not-found-error for Listener resource %q", r.ldsResourceName)
-	}
+	r.logger.Warningf("Received resource-not-found-error for Listener resource %q", r.ldsResourceName)
 
 	r.listenerUpdateRecvd = false
-
 	if r.routeConfigWatcher != nil {
 		r.routeConfigWatcher.stop()
 	}
@@ -596,9 +593,7 @@ func (r *xdsResolver) onRouteConfigResourceError(name string, err error) {
 
 // Only executed in the context of a serializer callback.
 func (r *xdsResolver) onRouteConfigResourceNotFound(name string) {
-	if r.logger.V(2) {
-		r.logger.Infof("Received resource-not-found-error for RouteConfiguration resource %q", name)
-	}
+	r.logger.Warningf("Received resource-not-found-error for RouteConfiguration resource %q", name)
 
 	if r.rdsResourceName != name {
 		return

xds/internal/server/listener_wrapper.go

@@ -460,9 +460,7 @@ func (lw *ldsWatcher) OnResourceDoesNotExist(onDone xdsresource.OnDoneFunc) {
 		lw.logger.Warningf("Resource %q received resource-does-not-exist error after listener was closed", lw.name)
 		return
 	}
-	if lw.logger.V(2) {
-		lw.logger.Infof("LDS watch for resource %q reported resource-does-not-exist error", lw.name)
-	}
+	lw.logger.Warningf("LDS watch for resource %q reported resource-does-not-exist error", lw.name)
 
 	err := xdsresource.NewErrorf(xdsresource.ErrorTypeResourceNotFound, "resource name %q of type Listener not found in received response", lw.name)
 	lw.parent.onLDSResourceDoesNotExist(err)

xds/internal/server/rds_handler.go

@@ -187,9 +187,7 @@ func (rw *rdsWatcher) OnResourceDoesNotExist(onDone xdsresource.OnDoneFunc) {
 		return
 	}
 	rw.mu.Unlock()
-	if rw.logger.V(2) {
-		rw.logger.Infof("RDS watch for resource %q reported resource-does-not-exist error", rw.routeName)
-	}
+	rw.logger.Warningf("RDS watch for resource %q reported resource-does-not-exist error", rw.routeName)
 	err := xdsresource.NewErrorf(xdsresource.ErrorTypeResourceNotFound, "resource name %q of type RouteConfiguration not found in received response", rw.routeName)
 	err = fmt.Errorf("[xDS node id: %v]: %w", rw.parent.xdsNodeID, err)
 	rw.parent.handleRouteUpdate(rw.routeName, rdsWatcherUpdate{err: err})