Skip to content

Commit 3aa7457

Browse files
pradeepmvnmenghanl
authored andcommitted
xds client: Updated v3 type for http connection manager (#4137)
1 parent 2d61c30 commit 3aa7457

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

xds/internal/client/client_lds_test.go

+3-5
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ import (
2929
v3listenerpb "github.com/envoyproxy/go-control-plane/envoy/config/listener/v3"
3030
v3httppb "github.com/envoyproxy/go-control-plane/envoy/extensions/filters/network/http_connection_manager/v3"
3131
"github.com/golang/protobuf/proto"
32+
"github.com/golang/protobuf/ptypes"
3233
anypb "github.com/golang/protobuf/ptypes/any"
3334
"github.com/google/go-cmp/cmp"
3435
"github.com/google/go-cmp/cmp/cmpopts"
@@ -84,14 +85,11 @@ func (s) TestUnmarshalListener(t *testing.T) {
8485
},
8586
},
8687
}
87-
mcm, _ := proto.Marshal(cm)
88+
mcm, _ := ptypes.MarshalAny(cm)
8889
lis := &v3listenerpb.Listener{
8990
Name: v3LDSTarget,
9091
ApiListener: &v3listenerpb.ApiListener{
91-
ApiListener: &anypb.Any{
92-
TypeUrl: version.V3HTTPConnManagerURL,
93-
Value: mcm,
94-
},
92+
ApiListener: mcm,
9593
},
9694
}
9795
mLis, _ := proto.Marshal(lis)

xds/internal/version/version.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,6 @@ const (
4545
V3RouteConfigURL = "type.googleapis.com/envoy.config.route.v3.RouteConfiguration"
4646
V3ClusterURL = "type.googleapis.com/envoy.config.cluster.v3.Cluster"
4747
V3EndpointsURL = "type.googleapis.com/envoy.config.endpoint.v3.ClusterLoadAssignment"
48-
V3HTTPConnManagerURL = "type.googleapis.com/envoy.config.filter.network.http_connection_manager.v3.HttpConnectionManager"
48+
V3HTTPConnManagerURL = "type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager"
4949
V3UpstreamTLSContextURL = "type.googleapis.com/envoy.extensions.transport_sockets.tls.v3.UpstreamTlsContext"
5050
)

0 commit comments

Comments
 (0)