Only canonicalize header key once in each iteration (#1565)

ziyi-yan · web-flow · commit db30ebef9bcc · 2020-08-01T13:54:35.000-06:00
diff --git a/runtime/context.go b/runtime/context.go
@@ -96,8 +96,8 @@ func annotateContext(ctx context.Context, mux *ServeMux, req *http.Request, rpcM
 	}
 
 	for key, vals := range req.Header {
+		key = textproto.CanonicalMIMEHeaderKey(key)
 		for _, val := range vals {
-			key = textproto.CanonicalMIMEHeaderKey(key)
 			// For backwards-compatibility, pass through 'authorization' header with no prefix.
 			if key == "Authorization" {
 				pairs = append(pairs, "authorization", val)

Original file line number	Diff line number	Diff line change
`@@ -96,8 +96,8 @@ func annotateContext(ctx context.Context, mux ServeMux, req http.Request, rpcM`
`96`	`96`	`}`
`97`	`97`
`98`	`98`	`for key, vals := range req.Header {`
	`99`	`+ key = textproto.CanonicalMIMEHeaderKey(key)`
`99`	`100`	`for _, val := range vals {`
`100`		`- key = textproto.CanonicalMIMEHeaderKey(key)`
`101`	`101`	`// For backwards-compatibility, pass through 'authorization' header with no prefix.`
`102`	`102`	`if key == "Authorization" {`
`103`	`103`	`pairs = append(pairs, "authorization", val)`