Skip to content

Commit 15b2e49

Browse files
authored
Revert "Add supporting response_body field in the google.api.HttpRule (#712)"
This reverts commit e679739.
1 parent e679739 commit 15b2e49

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

43 files changed

+77
-1356
lines changed

Gopkg.lock

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Gopkg.toml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,6 @@ required = [
2323
revision = "6724a57986aff9bff1a1770e9347036def7c89f6"
2424
name = "github.com/rogpeppe/fastuuid"
2525

26-
[[constraint]]
27-
# Also defined in WORKSPACE
28-
revision = "383e8b2c3b9e36c4076b235b32537292176bae20"
29-
name = "google.golang.org/genproto"
30-
3126
[[override]]
3227
# Also defined in WORKSPACE
3328
revision = "eb3733d160e74a9c7e442f435eb3bea458e1d19f"
@@ -53,6 +48,12 @@ required = [
5348
version = "1.10.3"
5449
name = "google.golang.org/grpc"
5550

51+
[[constraint]]
52+
# Also defined in bazelbuild/rules_go
53+
# https://github.com/bazelbuild/rules_go/blob/436452edc29a2f1e0edc22d180fbb57c27e6d0af/go/private/repositories.bzl#L131
54+
revision = "86e600f69ee4704c6efbf6a2a40a5c10700e76c2"
55+
name = "google.golang.org/genproto"
56+
5657
[[constraint]]
5758
# Also defined in bazelbuild/rules_go
5859
# https://github.com/bazelbuild/rules_go/blob/436452edc29a2f1e0edc22d180fbb57c27e6d0af/go/private/repositories.bzl#L138

Makefile

Lines changed: 3 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -63,17 +63,13 @@ endif
6363
SWAGGER_EXAMPLES=examples/proto/examplepb/echo_service.proto \
6464
examples/proto/examplepb/a_bit_of_everything.proto \
6565
examples/proto/examplepb/wrappers.proto \
66-
examples/proto/examplepb/unannotated_echo_service.proto \
67-
examples/proto/examplepb/response_body_service.proto
68-
66+
examples/proto/examplepb/unannotated_echo_service.proto
6967
EXAMPLES=examples/proto/examplepb/echo_service.proto \
7068
examples/proto/examplepb/a_bit_of_everything.proto \
7169
examples/proto/examplepb/stream.proto \
7270
examples/proto/examplepb/flow_combination.proto \
7371
examples/proto/examplepb/wrappers.proto \
74-
examples/proto/examplepb/unannotated_echo_service.proto \
75-
examples/proto/examplepb/response_body_service.proto
76-
72+
examples/proto/examplepb/unannotated_echo_service.proto
7773
EXAMPLE_SVCSRCS=$(EXAMPLES:.proto=.pb.go)
7874
EXAMPLE_GWSRCS=$(EXAMPLES:.proto=.pb.gw.go)
7975
EXAMPLE_SWAGGERSRCS=$(SWAGGER_EXAMPLES:.proto=.swagger.json)
@@ -109,14 +105,7 @@ UNANNOTATED_ECHO_EXAMPLE_SRCS=$(EXAMPLE_CLIENT_DIR)/unannotatedecho/api_client.g
109105
$(EXAMPLE_CLIENT_DIR)/unannotatedecho/configuration.go \
110106
$(EXAMPLE_CLIENT_DIR)/unannotatedecho/examplepb_unannotated_simple_message.go \
111107
$(EXAMPLE_CLIENT_DIR)/unannotatedecho/unannotated_echo_service_api.go
112-
RESPONSE_BODY_EXAMPLE_SPEC=examples/proto/examplepb/response_body_service.swagger.json
113-
RESPONSE_BODY_EXAMPLE_SRCS=$(EXAMPLE_CLIENT_DIR)/responsebody/api_client.go \
114-
$(EXAMPLE_CLIENT_DIR)/responsebody/api_response.go \
115-
$(EXAMPLE_CLIENT_DIR)/responsebody/configuration.go \
116-
$(EXAMPLE_CLIENT_DIR)/responsebody/examplepb_response_body.go \
117-
$(EXAMPLE_CLIENT_DIR)/responsebody/response_body_service_api.go
118-
119-
EXAMPLE_CLIENT_SRCS=$(ECHO_EXAMPLE_SRCS) $(ABE_EXAMPLE_SRCS) $(UNANNOTATED_ECHO_EXAMPLE_SRCS) $(RESPONSE_BODY_EXAMPLE_SRCS)
108+
EXAMPLE_CLIENT_SRCS=$(ECHO_EXAMPLE_SRCS) $(ABE_EXAMPLE_SRCS) $(UNANNOTATED_ECHO_EXAMPLE_SRCS)
120109
SWAGGER_CODEGEN=swagger-codegen
121110

122111
PROTOC_INC_PATH=$(dir $(shell which protoc))/../include
@@ -175,12 +164,6 @@ $(UNANNOTATED_ECHO_EXAMPLE_SRCS): $(UNANNOTATED_ECHO_EXAMPLE_SPEC)
175164
@rm -f $(EXAMPLE_CLIENT_DIR)/unannotatedecho/README.md \
176165
$(EXAMPLE_CLIENT_DIR)/unannotatedecho/git_push.sh \
177166
$(EXAMPLE_CLIENT_DIR)/unannotatedecho/.travis.yml
178-
$(RESPONSE_BODY_EXAMPLE_SRCS): $(RESPONSE_BODY_EXAMPLE_SPEC)
179-
$(SWAGGER_CODEGEN) generate -i $(RESPONSE_BODY_EXAMPLE_SPEC) \
180-
-l go -o examples/clients/responsebody --additional-properties packageName=responsebody
181-
@rm -f $(EXAMPLE_CLIENT_DIR)/responsebody/README.md \
182-
$(EXAMPLE_CLIENT_DIR)/responsebody/git_push.sh \
183-
$(EXAMPLE_CLIENT_DIR)/responsebody/.travis.yml
184167

185168
examples: $(EXAMPLE_SVCSRCS) $(EXAMPLE_GWSRCS) $(EXAMPLE_DEPSRCS) $(EXAMPLE_SWAGGERSRCS) $(EXAMPLE_CLIENT_SRCS)
186169
test: examples

WORKSPACE

Lines changed: 11 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -12,51 +12,42 @@ http_archive(
1212
sha256 = "d03625db67e9fb0905bbd206fa97e32ae9da894fe234a493e7517fd25faec914",
1313
)
1414

15-
load("@io_bazel_rules_go//go:def.bzl", "go_repository")
16-
load("//:repositories.bzl", "repositories")
1715
load("@io_bazel_rules_go//go:def.bzl", "go_rules_dependencies", "go_register_toolchains")
1816

19-
# Also define in Gopkg.toml
20-
go_repository(
21-
name = "org_golang_google_genproto",
22-
commit = "383e8b2c3b9e36c4076b235b32537292176bae20",
23-
importpath = "google.golang.org/genproto",
24-
)
17+
go_rules_dependencies()
18+
19+
go_register_toolchains()
20+
21+
load("@bazel_gazelle//:deps.bzl", "gazelle_dependencies")
22+
23+
gazelle_dependencies()
24+
25+
load("@io_bazel_rules_go//go:def.bzl", "go_repository")
2526

26-
# Also define in Gopkg.toml
2727
go_repository(
2828
name = "com_github_rogpeppe_fastuuid",
2929
commit = "6724a57986aff9bff1a1770e9347036def7c89f6",
3030
importpath = "github.com/rogpeppe/fastuuid",
3131
)
3232

33-
# Also define in Gopkg.toml
3433
go_repository(
3534
name = "com_github_go_resty_resty",
3635
commit = "f8815663de1e64d57cdd4ee9e2b2fa96977a030e",
3736
importpath = "github.com/go-resty/resty",
3837
)
3938

40-
# Also define in Gopkg.toml
4139
go_repository(
4240
name = "com_github_ghodss_yaml",
4341
commit = "0ca9ea5df5451ffdf184b4428c902747c2c11cd7",
4442
importpath = "github.com/ghodss/yaml",
4543
)
4644

47-
# Also define in Gopkg.toml
4845
go_repository(
4946
name = "in_gopkg_yaml_v2",
5047
commit = "eb3733d160e74a9c7e442f435eb3bea458e1d19f",
5148
importpath = "gopkg.in/yaml.v2",
5249
)
5350

54-
repositories()
55-
56-
go_rules_dependencies()
57-
58-
go_register_toolchains()
59-
60-
load("@bazel_gazelle//:deps.bzl", "gazelle_dependencies")
51+
load("//:repositories.bzl", "repositories")
6152

62-
gazelle_dependencies()
53+
repositories()

examples/clients/responsebody/.gitignore

Lines changed: 0 additions & 24 deletions
This file was deleted.

examples/clients/responsebody/.swagger-codegen-ignore

Lines changed: 0 additions & 23 deletions
This file was deleted.

examples/clients/responsebody/api_client.go

Lines changed: 0 additions & 164 deletions
This file was deleted.

0 commit comments

Comments
 (0)