refacto to make the code easier and clearer

Author: jeremy-greenbids

modules/greenbidsBidAdapter.js

@@ -24,10 +24,10 @@ export const spec = {
    * @return boolean True if this is a valid bid, and false otherwise.
    */
   isBidRequestValid: function (bid) {
-    if (typeof bid.params !== 'undefined' && parseInt(getValue(bid.params, 'gbPlacementId')) > 0) {
+    if (typeof bid.params !== 'undefined' && parseInt(getValue(bid.params, 'placementId')) > 0) {
       return true;
     } else {
-      logError('Greenbids bidder adapter requires gbPlacementId to be defined and a positive number');
+      logError('Greenbids bidder adapter requires placementId to be defined and a positive number');
       return false;
     }
   },
@@ -117,7 +117,7 @@ export const spec = {
         ad: bid.ad,
         requestId: bid.bidId,
         creativeId: bid.creativeId,
-        gbPlacementId: bid.gbPlacementId,
+        placementId: bid.placementId,
       };
       if (bid.dealId) {
         bidResponse.dealId = bid.dealId
@@ -199,12 +199,12 @@ function getTimeToFirstByte(win) {
 
 function cleanBidsInfo(bids) {
   const reqObj = {};
-  let gbPlacementId = getValue(bids.params, 'gbPlacementId');
+  let placementId = getValue(bids.params, 'placementId');
   const gpid = deepAccess(bids, 'ortb2Imp.ext.gpid');
   reqObj.sizes = getSizes(bids);
   reqObj.bidId = getBidIdParameter('bidId', bids);
   reqObj.bidderRequestId = getBidIdParameter('bidderRequestId', bids);
-  reqObj.gbPlacementId = parseInt(gbPlacementId, 10);
+  reqObj.placementId = parseInt(placementId, 10);
   reqObj.adUnitCode = getBidIdParameter('adUnitCode', bids);
   reqObj.transactionId = bids.ortb2Imp?.ext?.tid || '';
   if (gpid) { reqObj.gpid = gpid; }

test/spec/modules/greenbidsBidAdapter_specs.js

@@ -26,7 +26,7 @@ describe('greenbidsBidAdapter', () => {
     let bid = {
       'bidder': 'greenbids',
       'params': {
-        'gbPlacementId': 4242
+        'placementId': 4242
       },
       'adUnitCode': 'adunit-code',
       'sizes': [[300, 250], [300, 600]],
@@ -51,7 +51,7 @@ describe('greenbidsBidAdapter', () => {
     let bidNonGBCompatible2 = {
       'bidder': 'greenbids',
       'params': {
-        'gbPlacementId': 'toto'
+        'placementId': 'toto'
       },
     };
 
@@ -841,7 +841,7 @@ describe('greenbidsBidAdapter', () => {
             'ttl': 360,
             'width': 300,
             'creativeId': 'er2ee',
-            'gbPlacementId': 4242
+            'placementId': 4242
           }, {
             'ad': AD_SCRIPT,
             'cpm': 0.5,
@@ -851,7 +851,7 @@ describe('greenbidsBidAdapter', () => {
             'ttl': 360,
             'width': 350,
             'creativeId': 'fs3ff',
-            'gbPlacementId': 4242,
+            'placementId': 4242,
             'dealId': 'ABC_123',
             'ext': {
               'dsa': {
@@ -881,7 +881,7 @@ describe('greenbidsBidAdapter', () => {
           'ad': AD_SCRIPT,
           'requestId': '3ede2a3fa0db94',
           'creativeId': 'er2ee',
-          'gbPlacementId': 4242
+          'placementId': 4242
         }, {
           'cpm': 0.5,
           'width': 350,
@@ -904,7 +904,7 @@ describe('greenbidsBidAdapter', () => {
           'ad': AD_SCRIPT,
           'requestId': '4fef3b4gb1ec15',
           'creativeId': 'fs3ff',
-          'gbPlacementId': 4242,
+          'placementId': 4242,
           'dealId': 'ABC_123'
         }
       ]
@@ -937,7 +937,7 @@ let bidRequests = [
   {
     'bidder': 'greenbids',
     'params': {
-      'gbPlacementId': 4242
+      'placementId': 4242
     },
     'adUnitCode': 'adunit-code',
     'sizes': [[300, 250], [300, 600]],