Merge pull request #22 from green-code-initiative/ISSUE_21

[ISSUE 21] depreciate irrelevant EC69 + delete deprecated EC66 + check 10.4.1 SonarQube compatibility

Author: dedece35

CHANGELOG.md

@@ -13,13 +13,18 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+- [#22](https://github.com/green-code-initiative/ecoCode-python/issues/22) Depreciation of EC69 rule for python because not relevant (after analysis)
+
 ### Deleted
 
+- [#22](https://github.com/green-code-initiative/ecoCode-python/issues/22) Delete deprecated EC66 rule for Python
+
 ## [1.4.3] - 2024-05-15
 
 ### Added
 
 - [#18](https://github.com/green-code-initiative/ecoCode-python/issues/18) Add support for SonarQube 10.4 "DownloadOnlyWhenRequired" feature
+- Add Support for SonarQube 10.4.1
 
 ### Changed
 

src/main/java/fr/greencodeinitiative/python/PythonRuleRepository.java

@@ -55,7 +55,6 @@ public String repositoryKey() {
   @Override
   public List<Class> checkClasses() {
     return Arrays.asList(
-            AvoidDoubleQuoteCheck.class,
             AvoidGettersAndSetters.class,
             AvoidGlobalVariableInFunctionCheck.class,
             AvoidSQLRequestInLoop.class,

src/main/java/fr/greencodeinitiative/python/checks/AvoidDoubleQuoteCheck.java

@@ -23,6 +23,11 @@
 import org.sonar.plugins.python.api.tree.Tree;
 import org.sonarsource.analyzer.commons.annotations.DeprecatedRuleKey;
 
+/**
+ * @deprecated not applicable for Python
+ * (check discussion inside issue https://github.com/green-code-initiative/ecoCode-python/issues/21)
+ */
+@Deprecated(forRemoval = true)
 @Rule(key = "EC69")
 @DeprecatedRuleKey(repositoryKey = "gci-python", ruleKey = "S69")
 public class NoFunctionCallWhenDeclaringForLoop extends PythonSubscriptionCheck {
@@ -38,4 +43,4 @@ public void initialize(Context context) {
             }
         });
     }
-}
+}

src/main/java/fr/greencodeinitiative/python/checks/NoFunctionCallWhenDeclaringForLoop.java

@@ -78,7 +78,7 @@ void testMetadata() {
 
   @Test
   void testRegistredRules() {
-    assertThat(repository.rules()).hasSize(12);
+    assertThat(repository.rules()).hasSize(11);
   }
 
   @Test

src/test/java/fr/greencodeinitiative/python/PythonRuleRepositoryTest.java

@@ -20,9 +20,10 @@
 import org.junit.Test;
 import org.sonar.python.checks.utils.PythonCheckVerifier;
 
+@Deprecated
 public class NoFunctionCallWhenDeclaringForLoopTest {
     @Test
     public void test() {
         PythonCheckVerifier.verify("src/test/resources/checks/noFunctionCallWhenDeclaringForLoop.py", new NoFunctionCallWhenDeclaringForLoop());
     }
-}
+}

src/test/java/fr/greencodeinitiative/python/checks/AvoidDoubleQuoteTest.java

@@ -6,4 +6,4 @@ def my_function():
     my_function()
     pass
 
-my_function()
+my_function()