-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib/integrations/awsoidc
test fails locally
#53687
Comments
Can you please confirm whether the #53698 fixes this? |
@marcoandredinis I also suspected that the region var plays a role here, but I don't have it set at all - and your proposed fix doesn't work in my case. |
I'm attaching a test log, if that helps. test-log.txt |
Also: running the test with |
No issues for me:
|
I was able to reproduce a failure by setting the env var
Hence, my fix. But it might be something else. Can you please check your |
@marcoandredinis Indeed, I investigated the environment variable, but forgot about the config file itself. Removing the default profile helped. The question remains whether this should or should not influence this unit test, so up to you whether to close this issue or fix it. Thanks! |
I'll try to merge #53698 because I still see value in that PR even if it doesn't fix the root cause of your use case. I'm fine leaving this as is for now. |
Ran using
go test ./lib/integrations/awsoidc
on Mac OS (Arm). Also visible when running viamake test-go-unit
. Error:The text was updated successfully, but these errors were encountered: