remove mapCat() in favor of Array#flatMap()

Author: dimaMachina

.changeset/plenty-candles-shave.md

@@ -0,0 +1,5 @@
+---
+'graphql-language-service': patch
+---
+
+remove `mapCat()` in favor of `Array#flatMap()`

packages/graphql-language-service/src/interface/getDiagnostics.ts

@@ -113,27 +113,24 @@ export function validateQuery(
     return [];
   }
 
-  const validationErrorAnnotations = mapCat(
-    validateWithCustomRules(schema, ast, customRules, isRelayCompatMode),
-    error => annotations(error, DIAGNOSTIC_SEVERITY.Error, 'Validation'),
+  const validationErrorAnnotations = validateWithCustomRules(
+    schema,
+    ast,
+    customRules,
+    isRelayCompatMode,
+  ).flatMap(error =>
+    annotations(error, DIAGNOSTIC_SEVERITY.Error, 'Validation'),
   );
 
   // TODO: detect if > [email protected], and use the new rule for this.
-  const deprecationWarningAnnotations = mapCat(
-    validate(schema, ast, [NoDeprecatedCustomRule]),
-    error => annotations(error, DIAGNOSTIC_SEVERITY.Warning, 'Deprecation'),
+  const deprecationWarningAnnotations = validate(schema, ast, [
+    NoDeprecatedCustomRule,
+  ]).flatMap(error =>
+    annotations(error, DIAGNOSTIC_SEVERITY.Warning, 'Deprecation'),
   );
   return validationErrorAnnotations.concat(deprecationWarningAnnotations);
 }
 
-// General utility for mapping-and-concatenating (aka flat-mapping).
-function mapCat<T>(
-  array: ReadonlyArray<T>,
-  mapper: (item: T) => Array<any>,
-): Array<any> {
-  return Array.prototype.concat.apply([], array.map(mapper));
-}
-
 function annotations(
   error: GraphQLError,
   severity: DiagnosticSeverity,