[IMP] sale_picking_quick_confirm user error text

Author: quentinDupont

sale_picking_quick_confirm/i18n/fr.po

@@ -6,8 +6,8 @@ msgid ""
 msgstr ""
 "Project-Id-Version: Odoo Server 16.0\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2025-02-24 09:02+0000\n"
-"PO-Revision-Date: 2025-02-24 09:02+0000\n"
+"POT-Creation-Date: 2025-03-24 15:12+0000\n"
+"PO-Revision-Date: 2025-03-24 15:12+0000\n"
 "Last-Translator: \n"
 "Language-Team: \n"
 "MIME-Version: 1.0\n"
@@ -20,17 +20,10 @@ msgstr ""
 msgid "Confirm Sale and Picking"
 msgstr "Confirmer Vente et BL"
 
-#. module: sale_picking_quick_confirm
-#. odoo-python
-#: code:addons/sale_picking_quick_confirm/models/stock_picking.py:0
-#, python-format
-msgid "Nothing to check the availability for."
-msgstr "Aucune ligne où l'on peut vérifier la disponibilité."
-
 #. module: sale_picking_quick_confirm
 #: model:ir.model,name:sale_picking_quick_confirm.model_sale_order
 msgid "Sales Order"
-msgstr "Commandes clients"
+msgstr "Commande client"
 
 #. module: sale_picking_quick_confirm
 #: model:ir.model,name:sale_picking_quick_confirm.model_stock_move
@@ -44,9 +37,11 @@ msgstr "Transfert"
 
 #. module: sale_picking_quick_confirm
 #. odoo-python
-#: code:addons/sale_picking_quick_confirm/models/stock_move.py:0
+#: code:addons/sale_picking_quick_confirm/models/stock_picking.py:0
 #, python-format
 msgid ""
-"We can't quickly validate picking because there's a move with a null demand."
+"We can't quickly validate picking because there's moves with a null demand: "
+"%s"
 msgstr ""
-"On ne peut pas valider rapidement le bon de livraison car il y a une quantité nulle."
+"On ne peut pas valider rapidement le bon de livraison car il y a des quantités nulles "
+"sur ces lignes : %s"

sale_picking_quick_confirm/models/stock_move.py

@@ -2,23 +2,14 @@
 # @author Quentin DUPONT ([email protected])
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 
-from odoo import _, models
-from odoo.exceptions import UserError
+from odoo import models
 
 
 class StockMove(models.Model):
     _inherit = "stock.move"
 
     def quick_quantity_done(self):
+        # Handling null quantities upstream in stock_picking quick_confirm()
         for move in self:
-            initial_demand = move.product_uom_qty
-            if initial_demand:
-                move.quantity_done = initial_demand
-                self._quantity_done_set()
-            else:
-                raise UserError(
-                    _(
-                        "We can't quickly validate picking because there's a "
-                        "move with a null demand."
-                    )
-                )
+            move.quantity_done = move.product_uom_qty
+            self._quantity_done_set()

sale_picking_quick_confirm/models/stock_picking.py

@@ -2,7 +2,8 @@
 # @author Quentin DUPONT ([email protected])
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 
-from odoo import models
+from odoo import _, models
+from odoo.exceptions import UserError
 
 
 class StockPicking(models.Model):
@@ -13,8 +14,22 @@ def quick_confirm(self):
             moves = picking.mapped("move_ids").filtered(
                 lambda move: move.state not in ("draft", "cancel", "done")
             )
-            # Fill picking moves
-            for move in moves:
-                move.quick_quantity_done()
-            # Validate picking
-            picking.button_validate()
+            # Handling null quantities
+            moves_qty_zero = moves.filtered(lambda x: not x.product_uom_qty).mapped(
+                "product_id.name"
+            )
+            moves_qty_zero_str = ", ".join(map(str, moves_qty_zero))
+            if moves_qty_zero:
+                raise UserError(
+                    _(
+                        "We can't quickly validate picking because there's "
+                        "moves with a null demand: %s",
+                        moves_qty_zero_str,
+                    )
+                )
+            else:
+                # Fill picking moves
+                for move in moves:
+                    move.quick_quantity_done()
+                # Validate picking
+                picking.button_validate()