tk diff silently failing when ks diff works

[tomwilkie]

$ tk diff -v environments/default/hg-free-us-central1.default
Warning: `namespace` is deprecated, use `spec.namespace` instead.
Warning: `server` is deprecated, use `spec.apiServer` instead.
Warning: `team` is deprecated, use `metadata.labels.team` instead.


$ echo $?
16

[issue-label-bot]

Issue-Label Bot is automatically applying the label kind/bug to this issue, with a confidence of 0.91. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

[tomwilkie]

This is using the native kubectl diff

[tomwilkie]

Made tk print the kubectl error:

$ tk diff -v environments/default/hg-free-us-central1.default
Warning: `namespace` is deprecated, use `spec.namespace` instead.
Warning: `server` is deprecated, use `spec.apiServer` instead.
Warning: `team` is deprecated, use `metadata.labels.team` instead.
Error from server (Forbidden): clusterroles.rbac.authorization.k8s.io "prometheus-one" is forbidden: user "[email protected]" (groups=["system:authenticated"]) is attempting to grant RBAC permissions not currently held:
{APIGroups:[""], Resources:["endpoints"], Verbs:["get" "list" "watch"]}
{APIGroups:[""], Resources:["nodes"], Verbs:["get" "list" "watch"]}
{APIGroups:[""], Resources:["nodes/proxy"], Verbs:["get" "list" "watch"]}
{APIGroups:[""], Resources:["pods"], Verbs:["get" "list" "watch"]}
{APIGroups:[""], Resources:["services"], Verbs:["get" "list" "watch"]}
{NonResourceURLs:["/metrics"], Verbs:["get"]}

• Interesting that ksonnet works...
• Also, weird that kubectl diff using 1 for the presence of a diff or an RBAC error.

[tomwilkie]

kubernetes/kubectl#707