Skip to content

tk apply diff error UX improvements #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jdbaldry opened this issue Jul 23, 2020 · 2 comments · Fixed by #339
Closed

tk apply diff error UX improvements #324

jdbaldry opened this issue Jul 23, 2020 · 2 comments · Fixed by #339
Labels
kind/feature Something new should be added
Milestone

Comments

@jdbaldry
Copy link
Member

jdbaldry commented Jul 23, 2020

When running a tk apply, if a diff error is encountered, the command will still prompt the user to "Please type 'yes' to confirm:". As a user, I would prefer not to apply changes unless I have complete information and feel that a diff failure should be notably different to the warning of an empty diff.

It would also be nice to provide a way of avoiding diff issues in some way. For instance, a common source of diff errors is admission webhooks that do not support dry run applies. In these circumstances the entire diff fails and it would be nice for the user to be able specify a way of ignoring the failing resources during the diff stage. Perhaps an inverse of the -t, --target flag.

@issue-label-bot issue-label-bot bot added the kind/feature Something new should be added label Jul 23, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label kind/feature to this issue, with a confidence of 0.98. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@Duologic
Copy link
Member

Perhaps an inverse of the -t, --target flag.

Yes, so much yes. I can see it very useful in a test environment where multiple people are working in the same Tanka environment and your branches just drift a bit, you can quickly skip that one or two resources the other dev has applied.

@sh0rez sh0rez added this to the 0.12 milestone Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Something new should be added
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants