fix: ensure metadata.name is set on loading an env

Duologic · Duologic · commit 4ee8de78f22e · 2020-11-20T10:13:14.000+01:00
diff --git a/pkg/tanka/parse.go b/pkg/tanka/parse.go
@@ -74,6 +74,10 @@ func load(path string, opts Opts) (*loaded, error) {
 		return nil, fmt.Errorf("no Tanka environment found")
 	}
 
+	if env.Metadata.Name == "" {
+		return nil, fmt.Errorf("Environment has no metadata.name set in %s", path)
+	}
+
 	if err := checkVersion(env.Spec.ExpectVersions.Tanka); err != nil {
 		return nil, err
 	}

Original file line number	Diff line number	Diff line change
`@@ -74,6 +74,10 @@ func load(path string, opts Opts) (*loaded, error) {`
`74`	`74`	`return nil, fmt.Errorf("no Tanka environment found")`
`75`	`75`	`}`
`76`	`76`
	`77`	`+ if env.Metadata.Name == "" {`
	`78`	`+ return nil, fmt.Errorf("Environment has no metadata.name set in %s", path)`
	`79`	`+ }`
	`80`	`+`
`77`	`81`	`if err := checkVersion(env.Spec.ExpectVersions.Tanka); err != nil {`
`78`	`82`	`return nil, err`
`79`	`83`	`}`