Skip to content

Commit 4df6ff7

Browse files
authored
ci: use ncipollo/release-action for uploading release artifacts (#1292)
1 parent 336b926 commit 4df6ff7

File tree

1 file changed

+9
-43
lines changed

1 file changed

+9
-43
lines changed

.github/workflows/release-please.yml

+9-43
Original file line numberDiff line numberDiff line change
@@ -55,54 +55,20 @@ jobs:
5555
fetch-depth: 0
5656
ref: "${{ needs.release-please.outputs.release_tag }}"
5757

58-
- name: Look up release
59-
id: lookup-release
60-
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
61-
with:
62-
script: |
63-
const currentTag = "${{ needs.release-please.outputs.release_tag }}";
64-
core.info(`Looking for release associated with '${currentTag}'`);
65-
const release = await github.rest.repos.getReleaseByTag({
66-
owner: context.repo.owner,
67-
repo: context.repo.repo,
68-
tag: currentTag
69-
});
70-
core.info(`Release found: ${release.data.id}'`);
71-
core.setOutput('release_id', release.data.id);
72-
73-
7458
- uses: ./.github/actions/setup-goversion
7559

7660
- name: Build binaries
7761
run: make cross
7862

7963
- name: Attach binaries
80-
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
64+
uses: ncipollo/release-action@2c591bcc8ecdcd2db72b97d6147f871fcd833ba5 # v1.14.0
8165
with:
82-
github-token: ${{ github.token }}
83-
script: |
84-
const path = require('node:path');
85-
const fs = require('node:fs/promises');
86-
87-
const releaseId = '${{ steps.lookup-release.outputs.release_id }}';
88-
const globber = await glob.create('dist/*');
89-
90-
for await (const file of globber.globGenerator()) {
91-
const filename = path.basename(file);
92-
try {
93-
await github.rest.repos.uploadReleaseAsset({
94-
owner: context.repo.owner,
95-
repo: context.repo.repo,
96-
release_id: releaseId,
97-
name: filename,
98-
data: await fs.readFile(file),
99-
});
100-
} catch (e) {
101-
if (e.status === 422) {
102-
core.setFailed(`${filename} already attached to release`);
103-
return;
104-
}
105-
throw e;
106-
}
107-
}
66+
token: ${{ github.token }}
67+
allowUpdates: true
68+
tag: ${{ needs.release-please.outputs.release_tag }}
69+
omitNameDuringUpdate: true
70+
omitPrereleaseDuringUpdate: true
71+
omitBodyDuringUpdate: true
72+
omitDraftDuringUpdate: true
73+
artifacts: "dist/**/*"
10874

0 commit comments

Comments
 (0)