Skip to content

Commit d08f7da

Browse files
authored
Fix -compactor.consistency-delay description (#2324)
Signed-off-by: Marco Pracucci <[email protected]>
1 parent 72629a8 commit d08f7da

File tree

4 files changed

+4
-9
lines changed

4 files changed

+4
-9
lines changed

cmd/mimir/config-descriptor.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5486,7 +5486,7 @@
54865486
"kind": "field",
54875487
"name": "consistency_delay",
54885488
"required": false,
5489-
"desc": "Minimum age of fresh (non-compacted) blocks before they are being processed. Malformed blocks older than the maximum of consistency-delay and 48h0m0s will be removed.",
5489+
"desc": "Minimum age of fresh (non-compacted) blocks before they are being processed.",
54905490
"fieldValue": null,
54915491
"fieldDefaultValue": 0,
54925492
"fieldFlag": "compactor.consistency-delay",

cmd/mimir/help-all.txt.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -546,7 +546,7 @@ Usage of ./cmd/mimir/mimir:
546546
-compactor.compactor-tenant-shard-size int
547547
Max number of compactors that can compact blocks for single tenant. 0 to disable the limit and use all compactors.
548548
-compactor.consistency-delay duration
549-
Minimum age of fresh (non-compacted) blocks before they are being processed. Malformed blocks older than the maximum of consistency-delay and 48h0m0s will be removed.
549+
Minimum age of fresh (non-compacted) blocks before they are being processed.
550550
-compactor.data-dir string
551551
Directory to temporarily store blocks during compaction. This directory is not required to be persisted between restarts. (default "./data-compactor/")
552552
-compactor.deletion-delay duration

docs/sources/operators-guide/configuring/reference-configuration-parameters/index.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3559,8 +3559,7 @@ The `compactor` block configures the compactor component.
35593559
[meta_sync_concurrency: <int> | default = 20]
35603560
35613561
# (advanced) Minimum age of fresh (non-compacted) blocks before they are being
3562-
# processed. Malformed blocks older than the maximum of consistency-delay and
3563-
# 48h0m0s will be removed.
3562+
# processed.
35643563
# CLI flag: -compactor.consistency-delay
35653564
[consistency_delay: <duration> | default = 0s]
35663565

pkg/compactor/compactor.go

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,6 @@ const (
4545
const (
4646
blocksMarkedForDeletionName = "cortex_compactor_blocks_marked_for_deletion_total"
4747
blocksMarkedForDeletionHelp = "Total number of blocks marked for deletion in compactor."
48-
49-
// PartialUploadThresholdAge is a time after partial block is assumed aborted and ready to be cleaned.
50-
// Keep it long as it is based on block creation time not upload start time.
51-
PartialUploadThresholdAge = 2 * 24 * time.Hour
5248
)
5349

5450
var (
@@ -127,7 +123,7 @@ func (cfg *Config) RegisterFlags(f *flag.FlagSet, logger log.Logger) {
127123
cfg.retryMaxBackoff = time.Minute
128124

129125
f.Var(&cfg.BlockRanges, "compactor.block-ranges", "List of compaction time ranges.")
130-
f.DurationVar(&cfg.ConsistencyDelay, "compactor.consistency-delay", 0, fmt.Sprintf("Minimum age of fresh (non-compacted) blocks before they are being processed. Malformed blocks older than the maximum of consistency-delay and %s will be removed.", PartialUploadThresholdAge))
126+
f.DurationVar(&cfg.ConsistencyDelay, "compactor.consistency-delay", 0, "Minimum age of fresh (non-compacted) blocks before they are being processed.")
131127
f.IntVar(&cfg.BlockSyncConcurrency, "compactor.block-sync-concurrency", 8, "Number of Go routines to use when downloading blocks for compaction and uploading resulting blocks.")
132128
f.IntVar(&cfg.MetaSyncConcurrency, "compactor.meta-sync-concurrency", 20, "Number of Go routines to use when syncing block meta files from the long term storage.")
133129
f.StringVar(&cfg.DataDir, "compactor.data-dir", "./data-compactor/", "Directory to temporarily store blocks during compaction. This directory is not required to be persisted between restarts.")

0 commit comments

Comments
 (0)