OTLP: add config flag to enable 'quiet zeros' insertion

We need to ensure all receivers of the data can handle it, before we start sending.

Signed-off-by: Bryan Boreham <[email protected]>

Author: bboreham

storage/remote/otlptranslator/prometheusremotewrite/helper.go

@@ -622,7 +622,11 @@ func (c *PrometheusConverter) handleStartTime(startTs, ts int64, labels []prompb
 
 	logger.Debug("adding zero value at start_ts", "type", typ, "labels", labelsStringer(labels), "start_ts", startTs, "sample_ts", ts, "sample_value", val)
 
-	c.addSample(&prompb.Sample{Timestamp: startTs, Value: math.Float64frombits(value.QuietZeroNaN)}, labels)
+	var createdTimeValue float64
+	if settings.EnableStartTimeQuietZero {
+		createdTimeValue = math.Float64frombits(value.QuietZeroNaN)
+	}
+	c.addSample(&prompb.Sample{Timestamp: startTs, Value: createdTimeValue}, labels)
 }
 
 // handleHistogramStartTime similar to the method above but for native histograms..

storage/remote/otlptranslator/prometheusremotewrite/helper_test.go

@@ -478,6 +478,7 @@ func TestPrometheusConverter_AddSummaryDataPoints(t *testing.T) {
 				Settings{
 					ExportCreatedMetric:                        true,
 					EnableCreatedTimestampZeroIngestion:        true,
+					EnableStartTimeQuietZero:                   true,
 					ValidIntervalCreatedTimestampZeroIngestion: tt.overrideValidInterval,
 				},
 				metric.Name(),

storage/remote/otlptranslator/prometheusremotewrite/metrics_to_prw.go

@@ -47,6 +47,7 @@ type Settings struct {
 
 	// Mimir specifics.
 	EnableCreatedTimestampZeroIngestion        bool
+	EnableStartTimeQuietZero                   bool
 	ValidIntervalCreatedTimestampZeroIngestion time.Duration
 }