Fix /monitoring endpoint (#10872)

* changes

* add changeset

* Update routes.py

* add changeset

* changes

---------

Co-authored-by: Ali Abid <[email protected]>
Co-authored-by: gradio-pr-bot <[email protected]>

Author: 3 people

.changeset/curly-eagles-stand.md

@@ -0,0 +1,5 @@
+---
+"gradio": patch
+---
+
+fix:Fix `/monitoring` endpoint

gradio/monitoring_dashboard.py

@@ -56,6 +56,8 @@
         outputs=[plot, unique_users, total_requests, process_time],
     )
     def gen_plot(start, end, selected_fn):
+        if len(data["data"]) == 0:
+            return {plot: gr.skip()}
         df = pd.DataFrame(list(data["data"].values()))
         if selected_fn != "All":
             df = df[df["function"] == selected_fn]

gradio/routes.py

@@ -1620,7 +1620,7 @@ def manifest_json():
                 media_type="application/manifest+json",
             )
 
-        @router.get("/monitoring", dependencies=[Depends(login_check)])
+        @app.get("/monitoring", dependencies=[Depends(login_check)])
         async def analytics_login(request: fastapi.Request):
             if not blocks.enable_monitoring:
                 raise HTTPException(
@@ -1635,7 +1635,7 @@ async def analytics_login(request: fastapi.Request):
             print(f"* Monitoring URL: {monitoring_url} *")
             return HTMLResponse("See console for monitoring URL.")
 
-        @router.get("/monitoring/{key}")
+        @app.get("/monitoring/{key}")
         async def analytics_dashboard(key: str):
             if not blocks.enable_monitoring:
                 raise HTTPException(
@@ -1866,4 +1866,5 @@ async def new_lifespan(app: FastAPI):
     "assets",
     "favicon.ico",
     "gradio_api",
+    "monitoring",
 ]

test/test_routes.py

@@ -680,7 +680,7 @@ def test_monitoring_link(self):
 
         app, _, _ = demo.launch(prevent_thread_lock=True)
         client = TestClient(app)
-        response = client.get(f"{API_PREFIX}/monitoring")
+        response = client.get("/monitoring")
         assert response.status_code == 200
 
     def test_monitoring_link_disabled(self):
@@ -691,7 +691,7 @@ def test_monitoring_link_disabled(self):
 
         app, _, _ = demo.launch(prevent_thread_lock=True, enable_monitoring=False)
         client = TestClient(app)
-        response = client.get(f"{API_PREFIX}/monitoring")
+        response = client.get("/monitoring")
         assert response.status_code == 403
 
 
@@ -784,14 +784,14 @@ def test_monitoring_route(self):
         )
 
         response = client.get(
-            f"{API_PREFIX}/monitoring",
+            "/monitoring",
         )
         assert response.status_code == 200
 
         response = client.get("/logout")
 
         response = client.get(
-            f"{API_PREFIX}/monitoring",
+            "/monitoring",
         )
         assert response.status_code == 401