Added checks and backups for the output directory

Author: theRookieCoder

CHANGELOG.md

@@ -13,6 +13,11 @@
   - If `--import "Profile Name"` is provided, the mods from the `Profile Name` profile will be imported
 - Only check internet connection for subcommands which need it
   - Extract internet connection check function
+- Created a `check_output_directory()` that uhhh.. checks the output directory
+  - If it's not called `mods`, it will output a warning
+  - If it contains stuff, it will ask if you want to create a backup
+    - So that you don't lose the stuff in there when you upgrade
+  - Along with the original relative directory check
 
 ## `v3.25.1`
 

Cargo.lock

@@ -30,6 +30,7 @@ lazy_static = "1.4"
 dialoguer = "0.10"
 serde_json = "1.0"
 itertools = "0.10"
+fs_extra = "1.2"
 colored = "2.0"
 ferinth = "2.2"
 libium = "1.11"

Cargo.toml

@@ -1,4 +1,4 @@
-use crate::subcommands::profile::{pick_minecraft_version, pick_mod_loader};
+use super::{check_output_directory, pick_minecraft_version, pick_mod_loader};
 use anyhow::Result;
 use dialoguer::{Input, Select};
 use libium::{config, file_picker};
@@ -53,7 +53,13 @@ pub async fn configure(
             if let Some(index) = selection {
                 match index {
                     0 => {
-                        if let Some(dir) = file_picker::pick_folder(&profile.output_dir).await {
+                        if let Some(dir) = file_picker::pick_folder(
+                            &profile.output_dir,
+                            "Pick an output directory",
+                        )
+                        .await
+                        {
+                            check_output_directory(&dir).await?;
                             profile.output_dir = dir;
                         }
                     },

src/subcommands/profile/configure.rs

@@ -1,10 +1,9 @@
+use super::{check_output_directory, check_profile_name, pick_minecraft_version};
 use anyhow::{bail, Result};
 use dialoguer::{Confirm, Input, Select};
 use libium::{config, file_picker, misc};
 use std::path::PathBuf;
 
-use super::{check_profile_name, pick_minecraft_version};
-
 #[allow(clippy::option_option)]
 pub async fn create(
     config: &mut config::structs::Config,
@@ -39,10 +38,10 @@ pub async fn create(
                 .with_prompt("Would you like to specify a custom mods directory?")
                 .interact()?
             {
-                if let Some(dir) = file_picker::pick_folder(&selected_mods_dir).await {
-                    if !dir.is_absolute() {
-                        bail!("The provided output directory is not absolute, i.e. it is a relative path")
-                    }
+                if let Some(dir) =
+                    file_picker::pick_folder(&selected_mods_dir, "Pick an output directory").await
+                {
+                    check_output_directory(&dir).await?;
                     selected_mods_dir = dir;
                 };
             }

src/subcommands/profile/create.rs

@@ -5,17 +5,22 @@ mod list;
 pub use configure::configure;
 pub use create::create;
 pub use delete::delete;
+use fs_extra::dir::{copy, CopyOptions};
 pub use list::list;
 
+use crate::THEME;
 use anyhow::{bail, Result};
-use dialoguer::Select;
+use colored::Colorize;
+use dialoguer::{Confirm, Select};
 use libium::{
     config::{self, structs::ModLoader},
-    misc,
+    file_picker, misc, HOME,
 };
+use std::path::PathBuf;
+use tokio::fs::read_dir;
 
-fn pick_mod_loader(default: Option<&ModLoader>) -> std::io::Result<ModLoader> {
-    let mut picker = Select::with_theme(&*crate::THEME);
+fn pick_mod_loader(default: Option<&ModLoader>) -> Result<ModLoader> {
+    let mut picker = Select::with_theme(&*THEME);
     picker
         .with_prompt("Which mod loader do you use?")
         .items(&["Quilt", "Fabric", "Forge"]);
@@ -36,7 +41,7 @@ fn pick_mod_loader(default: Option<&ModLoader>) -> std::io::Result<ModLoader> {
 
 async fn pick_minecraft_version() -> Result<String> {
     let mut latest_versions: Vec<String> = misc::get_major_mc_versions(10).await?;
-    let selected_version = Select::with_theme(&*crate::THEME)
+    let selected_version = Select::with_theme(&*THEME)
         .with_prompt("Which version of Minecraft do you play?")
         .items(&latest_versions)
         .default(0)
@@ -53,3 +58,22 @@ fn check_profile_name(config: &mut config::structs::Config, name: &str) -> Resul
     }
     Ok(())
 }
+
+async fn check_output_directory(output_dir: &PathBuf) -> Result<()> {
+    if output_dir.is_relative() {
+        bail!("The provided output directory is not absolute, i.e. it is a relative path")
+    }
+    if output_dir.file_name().unwrap() != "mods" {
+        println!("{}", "Warning! The output directory is not called `mods`. Most mod loaders will load a directory called `mods`.".bright_yellow())
+    }
+    if output_dir.exists() && read_dir(output_dir).await?.next_entry().await?.is_some() {
+        if Confirm::with_theme(&*THEME)
+            .with_prompt("Your output directory is not empty and it will be erased when upgrading. Would like to create a backup of it?")
+            .interact()?
+        {
+            let backup_dir = file_picker::pick_folder(&*HOME, "Where should the backup be made?").await.unwrap();
+            copy(output_dir, backup_dir, &CopyOptions::new())?;
+        }
+    }
+    Ok(())
+}