Skip to content
This repository was archived by the owner on Nov 15, 2017. It is now read-only.

If two versions http/https of same scope exist, unable to change to broader scope #102

Closed
gorhill opened this issue Dec 26, 2013 · 3 comments
Labels

Comments

@gorhill
Copy link
Owner

gorhill commented Dec 26, 2013

Case:

Go to http://vimeo.com, create site-level scope.
Go to https://vimeo.com, create site-level scope.

Go to https://vimeo.com, try to remove site-level scope by selecting global scope.

Result: Current scope is set to http://vimeo.com. Cannot go broader scope.

This happens because the scope to remove is inferred from the passed URL. Caller should be able to state exactly what scope he is trying to remove.

@gorhill
Copy link
Owner Author

gorhill commented Dec 26, 2013

Actually, the problem occurs in createTemporaryGlobalScope(), therefore given the name of the function, it should take care to remove all scopes which potentially occlude the wanted (global here) scope. I find this cleaner, the API would end up doing what it's name suggest it does.

@gorhill
Copy link
Owner Author

gorhill commented Dec 26, 2013

Also, I think the popup menu should offer more than the three choices: it should also offer the two versions of a scope, http and https for site- and domain-level scopes. Need to think.

@gorhill
Copy link
Owner Author

gorhill commented Dec 30, 2013

Fixed in in 0.7.2.0 (commit: 6e69669)

@gorhill gorhill closed this as completed Dec 30, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant