Skip to content

Commit f29f222

Browse files
authored
Merge branch 'main' into explicit-dynamic-routing-header
2 parents ef5e022 + 50a8693 commit f29f222

23 files changed

+155
-393
lines changed

PROPERTIES.bzl

+33
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
PROPERTIES = {
2+
"version.com_google_protobuf": "3.19.1",
3+
# Version of google-java-format is downgraded from 1.8 to 1.7, because 1.8 supports java 11 minimum, while our JRE is java 8.
4+
"version.google_java_format": "1.7",
5+
"version.com_google_api_common_java": "1.9.3",
6+
"version.io_grpc_java": "1.42.1",
7+
8+
# Common deps.
9+
"maven.com_google_guava_guava": "com.google.guava:guava:30.1-android",
10+
"maven.com_google_code_findbugs_jsr305": "com.google.code.findbugs:jsr305:3.0.0",
11+
"maven.com_google_auto_value_auto_value": "com.google.auto.value:auto-value:1.7.2",
12+
"maven.com_google_auto_value_auto_value_annotations": "com.google.auto.value:auto-value-annotations:1.7.2",
13+
"maven.com_google_code_gson": "com.google.code.gson:gson:2.8.6",
14+
"maven.com_google_protobuf_protobuf_java": "com.google.protobuf:protobuf-java:3.19.1",
15+
"maven.io_github_java_diff_utils": "io.github.java-diff-utils:java-diff-utils:4.0",
16+
"maven.javax_annotation_javax_annotation_api": "javax.annotation:javax.annotation-api:1.3.2",
17+
"maven.javax_validation_javax_validation_api": "javax.validation:validation-api:2.0.1.Final",
18+
19+
# Gapic YAML parsing for batching settings.
20+
"maven.org_yaml_snakeyaml": "org.yaml:snakeyaml:1.26",
21+
22+
# ServiceStubSettings class. Used only in generated code.
23+
"maven.org_threeten_threetenbp": "org.threeten:threetenbp:1.3.3",
24+
25+
# Testing.
26+
"maven.junit_junit": "junit:junit:4.13.1",
27+
# This hamcrest-core dependency is for running JUnit test manually, before JUnit 4.11 it's wrapped along with JUnit package.
28+
# But now it has to be explicitly added.
29+
"maven.org_hamcrest_hamcrest_core": "org.hamcrest:hamcrest-core:1.3",
30+
"maven.org_mockito_mockito_core": "org.mockito:mockito-core:2.21.0",
31+
# Keep in sync with gax-java.
32+
"maven.com_google_truth_truth": "com.google.truth:truth:1.1.2",
33+
}

WORKSPACE

-8
Original file line numberDiff line numberDiff line change
@@ -52,14 +52,6 @@ load("@com_google_api_gax_java//:repositories.bzl", "com_google_api_gax_java_rep
5252

5353
com_google_api_gax_java_repositories()
5454

55-
load("//:repository_rules.bzl", "gapic_generator_java_properties")
56-
57-
gapic_generator_java_properties(
58-
name = "gapic_generator_java_properties",
59-
file = "//:dependencies.properties",
60-
)
61-
62-
load("@gapic_generator_java_properties//:dependencies.properties.bzl", "PROPERTIES")
6355
load("//:repositories.bzl", "gapic_generator_java_repositories")
6456

6557
gapic_generator_java_repositories()

dependencies.properties

-40
This file was deleted.

repositories.bzl

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_jar")
1616
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
1717
load("@bazel_tools//tools/build_defs/repo:jvm.bzl", "jvm_maven_import_external")
18-
load("@gapic_generator_java_properties//:dependencies.properties.bzl", "PROPERTIES")
18+
load("//:PROPERTIES.bzl", "PROPERTIES")
1919

2020
def gapic_generator_java_repositories():
2121
# Import dependencies shared between Gradle and Bazel (i.e. maven dependencies)

repository_rules.bzl

-49
This file was deleted.

rules_bazel/java/integration_test.bzl

-89
This file was deleted.

rules_bazel/java/java_diff_test.bzl

-84
This file was deleted.

rules_java_gapic/BUILD.bazel

+1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ pkg_tar(
1010
files = {
1111
"resources/gradle/gradle/wrapper/gradle-wrapper.jar": "gradle/wrapper/gradle-wrapper.jar",
1212
"resources/gradle/gradle/wrapper/gradle-wrapper.properties": "gradle/wrapper/gradle-wrapper.properties",
13+
"resources/gradle/gradle.properties": "gradle.properties",
1314
"resources/gradle/gradlew": "gradlew",
1415
"resources/gradle/gradlew.bat": "gradlew.bat",
1516
},
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
org.gradle.jvmargs=-Xmx2048m

scripts/BUILD.bazel

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
package(default_visibility = ["//test/integration:__pkg__"])
22

3-
exports_files(["diff_gen_and_golden.sh"])
3+
exports_files(["diff_gen_and_golden.sh", "update_golden.sh"])

scripts/diff_gen_and_golden.sh

+3-3
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@ RAW_SRCJAR=$( find . -name '*_java_gapic_srcjar_raw.srcjar' )
88
mkdir unpacked src
99
cd unpacked
1010
unzip -q -c "../${RAW_SRCJAR}" temp-codegen.srcjar | jar x
11-
cp -rf src/main/java/* ../src
12-
cp -rf src/test/java/* ../src
13-
[ -d proto ] && cp -rf proto/src/main/java/* ../src
11+
cp -r src/main/java/* ../src
12+
cp -r src/test/java/* ../src
13+
[ -d proto ] && cp -r proto/src/main/java/* ../src
1414
cd ..
1515

1616
# Remove unneeded non-Java files, like MANIFEST

scripts/update_golden.sh

+25
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
#!/bin/sh
2+
3+
set -o errexit
4+
5+
API_NAME=$1
6+
RAW_SRCJAR=$( find . -name '*_java_gapic_srcjar_raw.srcjar' )
7+
8+
rm -rf srcjar_unpacked
9+
mkdir srcjar_unpacked
10+
cd srcjar_unpacked
11+
UNPACK_DIR=$PWD
12+
unzip -q -c "../${RAW_SRCJAR}" temp-codegen.srcjar | jar x
13+
14+
cd ${BUILD_WORKSPACE_DIRECTORY}/test/integration/goldens/${API_NAME}
15+
16+
# clear out existing Java and JSON files.
17+
find . -name '*.java' -delete
18+
find . -name 'gapic_metadata.json' -delete
19+
20+
cp -r ${UNPACK_DIR}/src/main/java/* .
21+
cp -r ${UNPACK_DIR}/src/test/java/* .
22+
[ -d ${UNPACK_DIR}/proto ] && cp -r ${UNPACK_DIR}/proto/src/main/java/* .
23+
24+
find . -name 'PlaceholderFile.java' -delete
25+
find . -type d -empty -delete

0 commit comments

Comments
 (0)