Skip to content

Commit f1927a5

Browse files
authored
fix: update the return type of setWaitTimeout for convience (#1751)
Thank you for opening a Pull Request! For general contributing guidelines, please refer to [contributing guide](https://togithub.com/googleapis/gapic-generator-java/blob/main/CONTRIBUTING.md) Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/gapic-generator-java/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #<issue_number_goes_here> ☕️
1 parent 9345240 commit f1927a5

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

gax-java/gax/clirr-ignored-differences.xml

+6
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,10 @@
77
<className>com/google/api/gax/paging/Page</className>
88
<method>* stream*(*)</method>
99
</difference>
10+
<difference>
11+
<differenceType>7006</differenceType>
12+
<className>com/google/api/gax/rpc/ServerStreamingCallSettings$Builder</className>
13+
<method>*setWaitTimeout*</method>
14+
<to>com.google.api.gax.rpc.ServerStreamingCallSettings$Builder</to>
15+
</difference>
1016
</differences>

gax-java/gax/src/main/java/com/google/api/gax/rpc/ServerStreamingCallSettings.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -299,8 +299,9 @@ public Duration getWaitTimeout() {
299299
* Set the maximum amount of time to wait for the next message from the server. {@link
300300
* Duration#ZERO} disables the check for abandoned streams.
301301
*/
302-
public void setWaitTimeout(@Nonnull Duration waitTimeout) {
302+
public Builder<RequestT, ResponseT> setWaitTimeout(@Nonnull Duration waitTimeout) {
303303
this.waitTimeout = waitTimeout;
304+
return this;
304305
}
305306

306307
@Override

0 commit comments

Comments
 (0)