Skip to content

Commit a14fb04

Browse files
committed
move todo
1 parent b27edf3 commit a14fb04

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/main/java/com/google/api/generator/gapic/composer/ServiceClientClassComposer.java

-2
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,6 @@ public static ServiceClientClassComposer instance() {
111111

112112
public GapicClass generate(
113113
Service service, Map<String, Message> messageTypes, Map<String, ResourceName> resourceNames) {
114-
// TODO(miraleung): Clean up the hierarchy to avoid pass another parameter (resourceNames is
115-
// only used for composing sample code).
116114
Map<String, TypeNode> types = createTypes(service, messageTypes);
117115
String className = getClientClassName(service);
118116
GapicClass.Kind kind = Kind.MAIN;

src/main/java/com/google/api/generator/gapic/model/GapicClass.java

+2
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@
1919

2020
@AutoValue
2121
public abstract class GapicClass {
22+
// TODO(miraleung): Clean up the hierarchy to avoid pass another parameter (resourceNames is
23+
// only used for composing sample code).
2224
// TODO(miraleung): Add enum for resource name classes.
2325
public enum Kind {
2426
MAIN,

0 commit comments

Comments
 (0)