Skip to content

Commit 625ecc5

Browse files
authored
fix: Add Geo common protos to Bazel test dependencies. (#2033)
The generated unit tests for google/maps/places is not compilable, this is due to a Geo common proto is not added to Bazel test dependencies. See cl/567435528 and yaqs/8970072045605879808 for details. In long term, the Bazel Java test should be replaced with Maven/Gradle tests, so all the dependencies are managed through the gapic-generator-java jar instead of Bazel. This should be done as part of the Hermetic build project, cc: @JoeWang1127
1 parent 97bf9ed commit 625ecc5

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

rules_java_gapic/java_gapic.bzl

+1
Original file line numberDiff line numberDiff line change
@@ -333,6 +333,7 @@ def java_gapic_library(
333333
# Test deps.
334334
actual_test_deps = [
335335
"@com_google_googleapis//google/type:type_java_proto", # Commonly used.
336+
"@com_google_googleapis//google/geo/type:viewport_java_proto", # Used by Geo.
336337
"@com_google_api_gax_java//gax:gax_testlib",
337338
"@com_google_code_gson_gson//jar",
338339
"@junit_junit//jar",

0 commit comments

Comments
 (0)