Skip to content

Commit 5f2d4e7

Browse files
authored
feat: Add shopping and chat common protos. (#2553)
This PR adds shopping and chat common protos. Once this is released and made it into google-cloud-java, we need to remove the corresponding modules in google-cloud-java, otherwise there would be compilation errors regarding duplicated classes. e.g. This [folder](https://togithub.com/googleapis/google-cloud-java/tree/main/java-shopping-merchant-reports/proto-google-shopping-merchant-reports-v1beta/src/main/java/com/google/shopping/type) need to be removed. In addition, hardcoded proto references in https://togithub.com/googleapis/sdk-platform-java/pull/2414 in hermetic build scripts need to be removed as well. Fixes #2018
1 parent 4b44a78 commit 5f2d4e7

File tree

1 file changed

+11
-0
lines changed

1 file changed

+11
-0
lines changed

java-common-protos/.OwlBot.yaml

+11
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,20 @@ deep-copy-regex:
2828
- source: "/google/cloud/audit/google-cloud-audit-java/proto-google-cloud-audit-java/src"
2929
dest: "/owl-bot-staging/java-common-protos/v1/proto-google-common-protos/src"
3030

31+
# For geo common protos
3132
- source: "/google/geo/type/google-geo-type-java/proto-google-geo-type-java/src"
3233
dest: "/owl-bot-staging/java-common-protos/v1/proto-google-common-protos/src"
3334

35+
# For shopping common protos
36+
- source: "/google/shopping/merchant/reports/v1beta/google-cloud-merchant-reports-v1beta-java"
37+
dest: "/owl-bot-staging/java-common-protos/v1/proto-google-common-protos/src"
38+
39+
# It is only used once in https://github.com/googleapis/googleapis/blob/master/google/chat/v1/BUILD.bazel#L47,
40+
# and technically not a common proto, maybe a violation of AIP-215 if it is not.
41+
# However, it's better to put it here so that we don't have to manually add it to BUILD.bazel file and hermetic build scripts.
42+
- source: "/google/apps/card/v1/google-apps-card-v1-java/proto-google-apps-card-v1-java"
43+
dest: "/owl-bot-staging/java-common-protos/v1/proto-google-common-protos/src"
44+
3445
- source: "/google/logging/type/google-logging-type-java/proto-google-logging-type-java/src"
3546
dest: "/owl-bot-staging/java-common-protos/v1/proto-google-common-protos/src"
3647

0 commit comments

Comments
 (0)