You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix: BaseApiTracer to noop on attemptFailed via overloaded method call (#3016)
Fixes#3015Fixes#3014
Gax tracing internally works with `attemptFailedDuration`, which
defaults to a no-op. Downstream libraries use `attemptFailed`, which has
a custom behavior. What happens when an attempt-failed event occurs is
that `attemptFailedDuration` is called instead (in favor of using
java.time methods internally). This fix makes `attemptFailedDuration`'s
behavior to delegate the logic to `attemptFailed`.
The downstreams will keep failing because the repos haven't got adapted
to the new change in gax. See the follow ups below.
### Fixes in `java-spanner`

### Fixes in `java-bigtable`

### Follow ups in `java-bigtable`
More failures in java-bigtable to be addressed in that repo:
```
Error: BigtableTableAdminSettingsTest.testToString:175 expected to contain: totalTimeout=PT13H32M
but was : BigtableTableAdminSettings{projectId=our-project-85, instanceId=our-instance-06,
...
```
Fixed in googleapis/java-bigtable#2274
### Follow ups in `java-spanner`
```
Error: Failures:
Error: CompositeTracerTest.testMethodsOverrideMetricsTracer:238 Method not found in compositeTracerMethods: public void com.google.api.gax.tracing.MetricsTracer.attemptFailedDuration(java.lang.Throwable,java.time.Duration)
```
Fixed in googleapis/java-spanner#3200
0 commit comments