You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In this PR:
- Add suffix to sample source folder
- Add unit tests
Context:
- The package name of grafeas is `io.grafeas.v1` which is not starts
with `com`. When copying samples to destination directory, we need to
change the suffix of source directory.
- grafeas doesn't have a valid api_id (empty string). Before this
change, the `api_id` will be populated as
`{library.api_shortname}.googleapis.com`, which is not correct. `api_id`
should not be populated to `.repo-metadata.json` if set to empty string.
With the library entry added in generation configuration:
```
- api_shortname: containeranalysis
name_pretty: Grafeas
product_documentation: https://grafeas.io
api_description: n/a
client_documentation: "https://cloud.google.com/java/docs/reference/grafeas/latest/overview"
release_level: stable
distribution_name: "io.grafeas:grafeas"
api_id: ""
codeowner_team: "@googleapis/aap-dpes"
library_name: grafeas
requires_billing: false
GAPICs:
- proto_path: grafeas/v1
```
The generated java-grafeas is in googleapis/google-cloud-java#10820
Copy file name to clipboardExpand all lines: library_generation/test/resources/test_mv_src/gapic/destination/java_gapic_srcjar/src/main/java/example_main.txt
Copy file name to clipboardExpand all lines: library_generation/test/resources/test_mv_src/gapic/destination/java_gapic_srcjar/src/test/java/example_test.txt
Copy file name to clipboardExpand all lines: library_generation/test/resources/test_mv_src/proto/destination/java_gapic_srcjar/proto/src/main/java/example_proto_main.txt
Copy file name to clipboardExpand all lines: library_generation/test/resources/test_mv_src/samples/destination_com/java_gapic_srcjar/samples/snippets/generated/src/main/java/com/example_com_sample.txt
Copy file name to clipboardExpand all lines: library_generation/test/resources/test_mv_src/samples/destination_io/java_gapic_srcjar/samples/snippets/generated/src/main/java/io/example_io_sample.txt
0 commit comments