Skip to content

failure-checker should say which packages failed to publish #4977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sofisl opened this issue Feb 10, 2023 · 4 comments
Closed

failure-checker should say which packages failed to publish #4977

sofisl opened this issue Feb 10, 2023 · 4 comments
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@sofisl
Copy link
Contributor

sofisl commented Feb 10, 2023

Failure checker tells me some releases may have failed, but not which:
googleapis/google-cloud-node#3975

I went through and manually confirmed which ones didn't release, but it would be great if the bot could say it in the description (specifically for monorepos).

@sofisl sofisl added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Feb 10, 2023
@chingor13
Copy link
Contributor

This is not really feasible. The bot does not have access to logs nor should it be able to parse them to determine what failed.

@sofisl
Copy link
Contributor Author

sofisl commented Feb 14, 2023

How does failurechecker determine that something was not published?

The reason I ask is because failurechecker keeps opening up issues for a given release (googleapis/google-cloud-node#3898) that it thinks didn't succeed, and every time I close it it reopens it because it accurately determines I must have missed one: https://github.com/googleapis/google-cloud-node/issues?q=is%3Aissue+is%3Aclosed+warning%3A+a+recent+release+failed. I thought this was because failurechecker was checking against a given package manager to see if the package was published, but if not, then maybe this reopening is a bug with failure checker that just happens to be right? shrug

@sofisl
Copy link
Contributor Author

sofisl commented Feb 15, 2023

Ok, I think this is actually a broken-clock-is-right-twice-a-day bug. I've confirmed that all the packages in this release have been published, and yet failurechecker keeps opening up a new bug. See latest here: googleapis/google-cloud-node#3981 (but there are many open for the same release)

@sofisl sofisl added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. and removed type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Feb 15, 2023
@sofisl
Copy link
Contributor Author

sofisl commented Feb 17, 2023

Talked to Ben, seems like I need to remove the autorelease: failed label.

@sofisl sofisl closed this as completed Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

3 participants