feat: Adding support of single shot download

[shubham-up-47]

Adding the support of single shot download using a boolean flag.

Some results using the script in the customer issue,

• Download speed with single_shot_download=false (default value) = 123 MB / sec
• Download speed with single_shot_download=true = 273 MB / sec
• RawDownload speed with single_shot_download=false (default value) = 131 MB / sec
• RawDownload speed with single_shot_download=true = 289 MB / sec

[chandra-siri]

@shubham-up-47 Please add unit tests.

[shubham-up-47]

@shubham-up-47 Please add unit tests.

Done.

[shubham-up-47]

Nit: Also please follow https://www.conventionalcommits.org/en/v1.0.0/#specification , we don't need (storage) , unlike C++ where it's a mono-repo

Done. Noted.

[danielduhh]

Design question: why put this behind an opt-in flag? Is there a non backwards compatible change that you're concerned about? Or is the flag temporary?

This requires a customer to take an extra step in order to benefit from the performance optimization.

[shubham-up-47]

Design question: why put this behind an opt-in flag? Is there a non backwards compatible change that you're concerned about? Or is the flag temporary?

This requires a customer to take an extra step in order to benefit from the performance optimization.

We wanted to keep the existing flow as it is and add the support of single_shot_download, that's why keeping its default value as False currently.

Later if everything works fine, then we will make the default value of single_shot_download flag as true.

[cojenco]

Left a few questions. Please also add system tests under TestRawDownload as well, thanks!

[cojenco]

Thanks for adding the note on memory consumption.

Based on the design doc, I understand we are introducing single shot download support in multiple phases. Note that if and when we want to have single_shot_download defaulted to True, that would be a breaking change and would require a major version bump, so something to keep in mind when planning for next version changes

[danielduhh]

@cojenco how is that a breaking change?

[shubham-up-47]

Sure @cojenco, will keep these things in mind.

[shubham-up-47]

Left a few questions. Please also add system tests under TestRawDownload as well, thanks!

Done, Actually TestRawDownload is inheriting the TestDownload class, that's why all the tests written in the TestDownload class are automatically running for the TestRawDownload class.

https://screenshot.googleplex.com/4GYUPuXSXVkT7uh