deps: Remove Python 3.7 and 3.8 as supported runtimes #2133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
chalmerlowe
added
the
do not merge
…googleapis/python-bigquery into fix-b387301099-remove-python-37
…googleapis/python-bigquery into fix-b387301099-remove-python-37
Linchin
reviewed
Feb 28, 2025
| @@ -33,7 +33,6 @@ export PYTHONUNBUFFERED=1 | |||
| env | grep KOKORO | |||
|
|
|||
| # Install nox | |||
| # `virtualenv==20.26.6` is added for Python 3.7 compatibility | |||
There was a problem hiding this comment.
should we remove virtualenv==20.26.6 because 3.7 is removed too?
There was a problem hiding this comment.
We want virtualenv.
I am testing locally to see if we can simply install virtualenv without specifying a version number.
There was a problem hiding this comment.
Somewhere Owlbot.py did some post processing and reverted that bit of code to add that change back in because it pulled in the template for certain files and overwrote my changes.
I edited owlbot.py so that it will not touch certain templates AND so that for certain templates that it will protect the edits that we need to have go through.
chalmerlowe
added
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
Linchin
approved these changes
Feb 28, 2025
This was referenced Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Update Python versions by dropping support for versions 3.7, 3.8.
Also includes minor fixes and tweaks needed to support the primary changes related to dropping runtimes.
This is a work in progress. Do not merge.