feat: Adds ForeignTypeInfo class and tests #2110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigquery
tswast
approved these changes
Jan 14, 2025
| class ForeignTypeInfo: | ||
| """Metadata about the foreign data type definition such as the system in which the | ||
| type is defined. | ||
| Args: |
There was a problem hiding this comment.
Nit: needs a blank line to separate the sections
Suggested change
| Args: | |
| Args: |
Linchin
reviewed
Jan 14, 2025
|
|
||
| def to_api_repr(self) -> dict: | ||
| """Build an API representation of this object. | ||
| Returns: |
There was a problem hiding this comment.
Suggested change
| Returns: | |
| Returns: |
similar to https://github.com/googleapis/python-bigquery/pull/2110/files#r1914849397
Linchin
reviewed
Jan 14, 2025
| def from_api_repr(cls, api_repr: Dict[str, Any]) -> "ForeignTypeInfo": | ||
| """Factory: constructs an instance of the class (cls) | ||
| given its API representation. | ||
| Args: |
There was a problem hiding this comment.
Suggested change
| Args: | |
| Args: |
same as https://github.com/googleapis/python-bigquery/pull/2110/files#r1914849397
Linchin
reviewed
Jan 14, 2025
| Args: | ||
| api_repr (Dict[str, Any]): | ||
| API representation of the object to be instantiated. | ||
| Returns: |
There was a problem hiding this comment.
Suggested change
| Returns: | |
| Returns: |
same as https://github.com/googleapis/python-bigquery/pull/2110/files#r1914849397
Linchin
approved these changes
Jan 14, 2025
| @@ -636,10 +690,10 @@ def from_api_repr(cls, api_repr: dict) -> SerDeInfo: | |||
| """Factory: constructs an instance of the class (cls) | |||
| given its API representation. | |||
| Args: | |||
There was a problem hiding this comment.
Suggested change
| Args: | |
| Args: |
| @@ -636,10 +690,10 @@ def from_api_repr(cls, api_repr: dict) -> SerDeInfo: | |||
| """Factory: constructs an instance of the class (cls) | |||
| given its API representation. | |||
| Args: | |||
| resource (Dict[str, Any]): | |||
| api_repr (Dict[str, Any]): | |||
| API representation of the object to be instantiated. | |||
| Returns: | |||
There was a problem hiding this comment.
Suggested change
| Returns: | |
| Returns: |
This was referenced Jan 21, 2025
chalmerlowe
added a commit
that referenced
this pull request
Jan 22, 2025
* Adds ForeignTypeInfo class and tests * Tweak to docstring * minor adjustment in test to enhance code coverage * Updates spacing in docstrings * More updates to spacing in docstrings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
ForeignTypeInfoclass and the associated tests, plus minor tweaks to support both of those changes.Also incorporates several small changes to correct some docstrings in other PANGEA classes for more uniformity across the PANGEA code additions.