-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: avoid blocking in download thread when using BQ Storage API #2034
fix: avoid blocking in download thread when using BQ Storage API #2034
Conversation
256b0f7
to
3f8bd10
Compare
Just dropping by to see if there's any concerns about this PR. |
This prevents a deadlock between the main thead and download threads when the threadpool is shutdown prematurely.
d3f2f1e
to
8eebb9d
Compare
I took a quick look. |
The So, I just put a
|
Looks like cover is passing. |
After sleeping on this, I do think it's important to try and cover the currently uncovered branch. I'll see what I can do in a follow-up PR today. Edit: mailed #2127 |
This prevents a deadlock between the main thead and download threads when the threadpool is shutdown prematurely.
Fixes #2032 🦕