Skip to content

Commit 2e4af92

Browse files
committed
update todo with thoughts on future perf update
1 parent e2e1c7d commit 2e4af92

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

google/cloud/bigquery/_job_helpers.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,9 @@ def _to_query_job(
156156
job_complete = query_response.get("jobComplete")
157157
if job_complete:
158158
query_job._properties["status"]["state"] = "DONE"
159-
# TODO: set first page of results if job is "complete"
159+
# TODO: set first page of results if job is "complete" (and there is
160+
# only 1 page of results? otherwise, need some awkward logic
161+
# for DB API and to_dataframe to get destination table)
160162
else:
161163
query_job._properties["status"]["state"] = "PENDING"
162164

0 commit comments

Comments
 (0)