feat: Fix graph visualization to work with latest spanner-graph-notebook code; also, allow visualization when only some columns are json. #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lso, add a test for the multi-column case.
…ses, but still show them in the tabular view, and don't block visualizing remaining columns
product-auto-label
bot
added
size: l
product-auto-label
bot
added
size: m
The mock query result must contain valid json so that the visualizer attempts to get launched, in order for the code path we're trying to test to get reached.
product-auto-label
bot
added
size: l
Problem is that, even though the port is not used in colab mode, the javascript still throws an error if it's undefined.
tswast
approved these changes
Mar 13, 2025
| @@ -57,8 +57,7 @@ | |||
| "bigframes": ["bigframes >= 1.17.0"], | |||
| "geopandas": ["geopandas >= 1.0.1"], | |||
| "spanner-graph-notebook": [ | |||
| "spanner-graph-notebook >= 1.1.1, <=1.1.1", | |||
| "networkx", | |||
| "spanner-graph-notebook >= 1.1.3", | |||
There was a problem hiding this comment.
Should we put an upper bound on this? Or are all the APIs we're using now pretty stable?
If need be, I'd be OK putting an upper bound if/when it becomes a problem. Ideally we'd install the spanner-graph-notebook package from the GitHub repo here in the prerelease_deps session https://github.com/googleapis/python-bigquery-magics/blob/main/noxfile.py#L431 similar to what we do here: https://github.com/googleapis/python-bigquery-pandas/blob/7bac1c7439dcdce09edac6461a5127321451daee/noxfile.py#L345-L351
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕